Skip to content

Commit f2c8f1c

Browse files
authored
Merge pull request #45 from Aparna-BS/iterable_validator
Handling empty iterable case in element_type_checker().
2 parents 13b3b4c + 0b0df25 commit f2c8f1c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pyvalid/validators/__iterable.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def element_type_checker(cls, val, elements_type):
6161
False:
6262
If at least one element of the iterable is not of required type.
6363
"""
64-
valid = False
64+
valid = True
6565
for element in val:
6666
valid = isinstance(element, elements_type)
6767
if not valid:

tests/test_iterable_validator.py

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def test_elements_type(self):
2525
self.assertTrue(validator([1, 3, 25, 14]))
2626
self.assertFalse(validator([3.56, 6.4532, 65.57, 5.546]))
2727
self.assertFalse(validator(['CPython', 'PyPy', 'Jython', 'Cython']))
28+
self.assertTrue(validator([])) # Ignore empty
2829

2930
validator = IterableValidator(elements_type=float)
3031
self.assertFalse(validator([1, 3, 25, 14]))

0 commit comments

Comments
 (0)