Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpcproxy: add support for WatchRequest_ProgressRequest #19711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

grpcproxy: add support for WatchRequest_ProgressRequest #19711

wants to merge 1 commit into from

Conversation

alexandrevilain
Copy link

Fixes #19710

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexandrevilain
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @alexandrevilain. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from cc944d6 to 4b202ef Compare April 4, 2025 13:58
@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 4b202ef to 8b9dd9a Compare April 7, 2025 07:51
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Apr 7, 2025
@henrybear327
Copy link
Contributor

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.31%. Comparing base (d6416b8) to head (8b9dd9a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
server/proxy/grpcproxy/watch.go 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/proxy/grpcproxy/watch.go 90.37% <64.28%> (-2.12%) ⬇️

... and 60 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19711      +/-   ##
==========================================
+ Coverage   65.98%   68.31%   +2.33%     
==========================================
  Files         421      421              
  Lines       35857    35871      +14     
==========================================
+ Hits        23659    24506     +847     
+ Misses      10791     9929     -862     
- Partials     1407     1436      +29

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6416b8...8b9dd9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandrevilain
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for ProgressRequest in gRPC proxy
3 participants
@alexandrevilain @k8s-ci-robot @henrybear327