Skip to content

Popover: dismissible button hover has a rounded corners mismatch #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 5 tasks
SkyeSeitz opened this issue Nov 17, 2023 · 2 comments
Closed
2 of 5 tasks

Popover: dismissible button hover has a rounded corners mismatch #8208

SkyeSeitz opened this issue Nov 17, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-06-25 - Jun ...

Comments

@SkyeSeitz
Copy link

SkyeSeitz commented Nov 17, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

The two right corners of the dismissible button hover have mismatched corner radiuses.

Easier to see in the current build
image
But will persist with #8194 's update to transparent actions.
image

Expected Behavior

Top right should match it's container's radius. Bottom right should have a border-radius of 0.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/popover/

Reproduction Steps

  1. Open Popover
  2. Hover dismissible button

Reproduction Version

1.10.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@SkyeSeitz SkyeSeitz added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 17, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. labels Nov 17, 2023
@SkyeSeitz SkyeSeitz mentioned this issue Nov 17, 2023
Merged
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 11, 2023
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jan 29, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
driskull added a commit that referenced this issue May 31, 2024
@driskull
fix(popover): correct border radius on close button. #8208
696277b
@driskull driskull mentioned this issue May 31, 2024
Merged
@driskull driskull self-assigned this May 31, 2024
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 31, 2024
driskull added a commit that referenced this issue Jun 6, 2024
@driskull
fix(popover): correct border radius on close button (#9485)
d0fba56 
**Related Issue:** #8208

## Summary

- Updates component to not have a bottom border radius when there is a
header present
@driskull driskull added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 6, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Jun 6, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.0:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @SkyeSeitz @DitwanP