fix: correctly handle version ranges in prefer-node-protocol (#454)

Author: scagood

lib/rules/prefer-node-protocol.js

@@ -9,7 +9,7 @@ const {
     getPropertyName,
 } = require("@eslint-community/eslint-utils")
 
-const { Range } = require("semver")
+const { subset, Range } = require("semver")
 
 const getConfiguredNodeVersion = require("../util/get-configured-node-version")
 const stripImportPathParams = require("../util/strip-import-path-params")
@@ -57,15 +57,12 @@ function isEnablingThisRule(context, moduleStyle) {
     const version = getConfiguredNodeVersion(context)
 
     // Only check Node.js version because this rule is meaningless if configured Node.js version doesn't match semver range.
-    if (!version.intersects(supportedRangeForEsm)) {
+    if (!subset(version, supportedRangeForEsm)) {
         return false
     }
 
     // Only check when using `require`
-    if (
-        moduleStyle === "require" &&
-        !version.intersects(supportedRangeForCjs)
-    ) {
+    if (moduleStyle === "require" && !subset(version, supportedRangeForCjs)) {
         return false
     }
 

tests/lib/rules/prefer-node-protocol.js

@@ -57,6 +57,10 @@ new RuleTester({
         'const fs = require("eslint-plugin-n");',
 
         // check disabling by supported Node.js versions
+        {
+            options: [{ version: ">=10.13.0" }],
+            code: 'import fs from "fs";',
+        },
         {
             options: [{ version: "12.19.1" }],
             code: 'import fs from "fs";',