Skip to content

Commit 871b4f9

Browse files
committed
Updates on the code to fix the auto rebasing mistakes
1 parent 7bed2f5 commit 871b4f9

File tree

12 files changed

+1389
-1802
lines changed

12 files changed

+1389
-1802
lines changed

core/helper-tools/src/main/java/esa/mo/helpertools/helpers/HelperMisc.java

+209-244
Large diffs are not rendered by default.

core/mo-services-impl/ccsds-common-impl/src/main/java/esa/mo/common/impl/provider/DirectoryProviderServiceImpl.java

+133-219
Large diffs are not rendered by default.

core/mo-services-impl/nmf-platform-generic-impl/src/main/java/esa/mo/platform/impl/provider/gen/GPSProviderServiceImpl.java

+288-435
Large diffs are not rendered by default.

core/nmf-composites/nanosat-mo-supervisor/src/main/java/esa/mo/nmf/nanosatmosupervisor/parameter/OBSWParameterManager.java

+65-59
Original file line numberDiff line numberDiff line change
@@ -50,80 +50,84 @@
5050
* @author Tanguy Soto
5151
*/
5252
public class OBSWParameterManager {
53-
/**
54-
* The logger
55-
*/
56-
private static final Logger LOGGER = Logger.getLogger(OBSWParameterManager.class.getName());
57-
58-
/**
59-
* Default OBSW parameter report interval (seconds)
60-
*/
61-
private static final int DEFAULT_REPORT_INTERVAL = 5;
62-
63-
/**
64-
* Helper to read the OBSW parameter from datapool.
65-
*/
66-
private final ParameterLister parameterLister;
67-
68-
/**
69-
* Maps each parameter proxy (object instance id of the ParameterIdentity in the supervisor) to
70-
* the OBSW parameter it represents.
71-
*/
72-
private Map<Long, OBSWParameter> proxyIdsToOBSWParams;
73-
74-
/**
75-
* Provides the OBSW parameter values
76-
*/
77-
private OBSWParameterValuesProvider valuesProvider;
78-
79-
public OBSWParameterManager(InputStream datapool)
80-
throws IOException, JAXBException, XMLStreamException {
81-
// Read from provided inputstreams
82-
parameterLister = new ParameterLister(datapool);
83-
84-
// Initialize the parameters proxies to OBSW parameter maps
85-
proxyIdsToOBSWParams = new HashMap<>();
86-
87-
// Instantiate the value provider
88-
HashMap<Identifier, OBSWParameter> parameterMap = parameterLister.getParameters();
89-
String defaultClass = "esa.mo.nmf.nanosatmosupervisor.parameter.DummyValuesProvider";
90-
String valuesProviderClass = System.getProperty("nmf.supervisor.parameter.valuesprovider.impl", defaultClass);
91-
92-
try {
93-
Constructor<?> c = Class.forName(valuesProviderClass).getConstructor(parameterMap.getClass());
94-
valuesProvider = (OBSWParameterValuesProvider) c.newInstance(new Object[] {parameterMap});
95-
} catch (Exception e) {
96-
LOGGER.log(Level.SEVERE,
97-
"Error initializing the values provider. Using dummy values provider.", e);
98-
valuesProvider = new DummyValuesProvider(parameterMap);
53+
54+
/**
55+
* The logger
56+
*/
57+
private static final Logger LOGGER = Logger.getLogger(OBSWParameterManager.class.getName());
58+
59+
/**
60+
* Default OBSW parameter report interval (seconds)
61+
*/
62+
private static final int DEFAULT_REPORT_INTERVAL = 5;
63+
64+
/**
65+
* Helper to read the OBSW parameter from datapool.
66+
*/
67+
private final ParameterLister parameterLister;
68+
69+
/**
70+
* Maps each parameter proxy (object instance id of the ParameterIdentity in
71+
* the supervisor) to the OBSW parameter it represents.
72+
*/
73+
private Map<Long, OBSWParameter> proxyIdsToOBSWParams;
74+
75+
/**
76+
* Provides the OBSW parameter values
77+
*/
78+
private OBSWParameterValuesProvider valuesProvider;
79+
80+
public OBSWParameterManager(InputStream datapool)
81+
throws IOException, JAXBException, XMLStreamException {
82+
// Read from provided inputstreams
83+
parameterLister = new ParameterLister(datapool);
84+
85+
// Initialize the parameters proxies to OBSW parameter maps
86+
proxyIdsToOBSWParams = new HashMap<>();
87+
88+
// Instantiate the value provider
89+
HashMap<Identifier, OBSWParameter> parameterMap = parameterLister.getParameters();
90+
String defaultClass = "esa.mo.nmf.nanosatmosupervisor.parameter.DummyValuesProvider";
91+
String valuesProviderClass = System.getProperty("nmf.supervisor.parameter.valuesprovider.impl", defaultClass);
92+
93+
try {
94+
Constructor<?> c = Class.forName(valuesProviderClass).getConstructor(parameterMap.getClass());
95+
valuesProvider = (OBSWParameterValuesProvider) c.newInstance(new Object[]{parameterMap});
96+
} catch (Exception e) {
97+
LOGGER.log(Level.SEVERE,
98+
"Error initializing the values provider. Using dummy values provider.", e);
99+
valuesProvider = new DummyValuesProvider(parameterMap);
100+
}
99101
}
100102

101103
/**
102-
* Registers proxies for the OBSW parameters using the provided registration object.
104+
* Registers proxies for the OBSW parameters using the provided registration
105+
* object.
103106
*
104107
* @param registrationObject The registration object
105108
*/
106109
public void registerParametersProxies(MCRegistration registrationObject) {
107110
// Sort parameters by id
108-
List<OBSWParameter> parameters = new ArrayList<>(parameterLister.getParameters().values());
111+
List<OBSWParameter> parameters
112+
= new ArrayList<>(parameterLister.getParameters().values());
109113
parameters.sort(Comparator.comparing(OBSWParameter::getId));
110114

111115
// Create the parameter proxies definitions
112116
ParameterDefinitionDetailsList paramDefs = new ParameterDefinitionDetailsList();
113117
IdentifierList paramIdentifiers = new IdentifierList();
114118

115119
for (OBSWParameter param : parameters) {
116-
paramDefs.add(new ParameterDefinitionDetails(param.getDescription(), HelperAttributes
117-
.attributeName2typeShortForm(param.getType()).byteValue(), "", false, new Duration(
118-
DEFAULT_REPORT_INTERVAL), null, null));
120+
paramDefs.add(new ParameterDefinitionDetails(param.getDescription(),
121+
HelperAttributes.attributeName2typeShortForm(param.getType()).byteValue(), "", false,
122+
new Duration(DEFAULT_REPORT_INTERVAL), null, null));
119123
paramIdentifiers.add(new Identifier(param.getName()));
120124
}
121125

122126
// Register the parameter proxies
123127
LongList proxyIds = registrationObject.registerParameters(paramIdentifiers, paramDefs);
124128
if (proxyIds == null || proxyIds.size() != parameters.size()) {
125129
LOGGER.log(Level.SEVERE,
126-
"Error while registering OBSW parameters proxies: returned IDs are null or some are missing");
130+
"Error while registering OBSW parameters proxies: returned IDs are null or some are missing");
127131
return;
128132
}
129133
for (int i = 0; i < proxyIds.size(); i++) {
@@ -133,30 +137,32 @@ public void registerParametersProxies(MCRegistration registrationObject) {
133137

134138
/**
135139
* Returns a value for a given OBSW parameter proxy.
136-
*
140+
*
137141
* @param parameterID ID of the parameter proxy
138142
* @return The value
139143
*/
140144
public Attribute getValue(Long parameterID) {
141-
Identifier obswParamIdentifier = new Identifier(proxyIdsToOBSWParams.get(parameterID).getName());
145+
Identifier obswParamIdentifier
146+
= new Identifier(proxyIdsToOBSWParams.get(parameterID).getName());
142147
return getValue(obswParamIdentifier);
143148
}
144149

145150
/**
146151
* Sets a new value to a given OBSW parameter.
147-
*
152+
*
148153
* @param newRawValue the new value
149154
* @return true if parameter is set, false otherwise.
150155
*/
151156
public Boolean setValue(ParameterRawValue newRawValue) {
152-
Identifier obswParamIdentifier = new Identifier(proxyIdsToOBSWParams.get(newRawValue.getParamInstId())
153-
.getName());
157+
Identifier obswParamIdentifier
158+
= new Identifier(proxyIdsToOBSWParams.get(newRawValue.getParamInstId()).getName());
154159
return setValue(newRawValue.getRawValue(), obswParamIdentifier);
155160
}
156161

157162
/**
158163
* @param parameterID The parameter ID to test
159-
* @return true if the ID corresponds to one of the parameter proxies registered by this class
164+
* @return true if the ID corresponds to one of the parameter proxies
165+
* registered by this class
160166
*/
161167
public boolean isOBSWParameterProxy(Long parameterID) {
162168
return proxyIdsToOBSWParams.containsKey(parameterID);
@@ -174,7 +180,7 @@ private Attribute getValue(Identifier identifier) {
174180

175181
/**
176182
* Sets a new value for the given OBSW parameter name.
177-
*
183+
*
178184
* @param rawValue The new value of the parameter
179185
* @param identifier Name of the parameter
180186
* @return True if parameter is set, false otherwise.

0 commit comments

Comments
 (0)