remove unnecessary compiler definition

add comments

Author: canepat

cmake/toolchain/wasi.cmake

@@ -17,6 +17,6 @@
 set(CMAKE_C_COMPILER /opt/wasi-sdk/bin/clang)
 set(CMAKE_CXX_COMPILER /opt/wasi-sdk/bin/clang++)
 
-add_compile_definitions(CATCH_CONFIG_NO_POSIX_SIGNALS CATCH_CONFIG_DISABLE_EXCEPTIONS JSON_HAS_FILESYSTEM=0)
+add_compile_definitions(CATCH_CONFIG_NO_POSIX_SIGNALS JSON_HAS_FILESYSTEM=0)
 
 include(${CMAKE_CURRENT_LIST_DIR}/cxx20.cmake)

cmd/test/CMakeLists.txt

@@ -20,6 +20,7 @@ find_package(magic_enum REQUIRED)
 # Silkworm Core Tests
 file(GLOB_RECURSE SILKWORM_CORE_TESTS CONFIGURE_DEPENDS "${SILKWORM_MAIN_SRC_DIR}/core/*_test.cpp")
 if(SILKWORM_WASM_API)
+  # Stub clang exception handlers on WASM after Catch2 3.x due to https://github.com/WebAssembly/wasi-sdk/issues/329
   add_executable(core_test "${SILKWORM_MAIN_SRC_DIR}/wasm/exception_handling_stub.cpp" ${SILKWORM_CORE_TESTS})
   # Skip generation of RPATH linker option for wasm-ld present by default after building Catch2 v3.6.0 from sources
   set_target_properties(core_test PROPERTIES SKIP_BUILD_RPATH TRUE)

silkworm/wasm/exception_handling_stub.cpp

@@ -16,12 +16,17 @@
 
 #include <cstdlib>
 
+// Stubs for clang exception handlers on WASM after upgrading Catch2 to version 3.x
+// This avoids undefined symbols at linking: https://github.com/WebAssembly/wasi-sdk/issues/329
+
 extern "C" {
+
 void __cxa_allocate_exception() {
     std::abort();
 }
 
 void __cxa_throw() {
     std::abort();
 }
+
 }