Skip to content

PRs not merged when merge label is added. #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bendavies opened this issue Mar 5, 2021 · 4 comments
Closed

PRs not merged when merge label is added. #691

bendavies opened this issue Mar 5, 2021 · 4 comments
Assignees
Labels

Comments

@bendavies
Copy link
Contributor

Hi,

Does this need github.event.action == 'labeled' added for this to work?

Steps required to reproduce the problem

  1. Have a PR raised by dependabot for a non dev dependency
  2. Add the merge label
  3. PR is not merged

Expected Result

  • PR is merged

Actual Result

  • PR is not merged
@bendavies bendavies changed the title auto merge when label added doesn't work PRs not merged when merge label is added. Mar 5, 2021
@bendavies
Copy link
Contributor Author

Maybe I'm not understanding how this is meant to be used.
I just made this work by:

  1. adding label.
  2. forcing the workflow to rerun.
  3. it merged.

How do you use it?

@localheinz
Copy link
Member

@bendavies

The way it works right now is not idea: you have to

  • add the label when you open a pull request or
  • add the label, and then commit again

I'd prefer it as well when adding the label queued the merge job to be run. I think this need to be solved with a separate application.

@localheinz localheinz self-assigned this Mar 9, 2021
@localheinz localheinz added the bug label Mar 9, 2021
@bendavies
Copy link
Contributor Author

thanks @localheinz !

@localheinz
Copy link
Member

Closing in light of #759.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants