Skip to content
This repository was archived by the owner on Mar 14, 2025. It is now read-only.

Commit 1e9c8b6

Browse files
committed
Deduplicate creation of requirements from version list
1 parent 1786cae commit 1e9c8b6

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

komodo/check_unused_package.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,11 @@
1212
from typing import Any
1313

1414
import yaml
15-
from packaging.requirements import Requirement
1615

1716
from komodo.prettier import load_yaml
1817
from komodo.yaml_file_types import ReleaseFile, RepositoryFile
1918

20-
from .pypi_dependencies import PypiDependencies
19+
from .pypi_dependencies import PypiDependencies, version_list_to_requirements
2120

2221

2322
@dataclass
@@ -62,12 +61,10 @@ def get_visibility(pkg):
6261
private_packages = {
6362
pkg for pkg in release_file.content if get_visibility(pkg) == "private"
6463
}
65-
public_packages = (
66-
Requirement(pkg)
67-
if version in {"master", "main"}
68-
else Requirement(f"{pkg}=={version}")
64+
public_packages = version_list_to_requirements(
65+
(pkg, version)
6966
for pkg, version in release_file.content.items()
70-
if get_visibility(pkg) in ("public", "private-plugin") and pkg != "python"
67+
if get_visibility(pkg) in ("public", "private-plugin")
7168
)
7269
dependencies = _extract_dependencies(
7370
release_file,

0 commit comments

Comments
 (0)