Skip to content

Commit d26a83d

Browse files
committed
fix: do not execute getValues callback of batch when all values are cached
1 parent 9ee69b0 commit d26a83d

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/cachified.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1192,6 +1192,7 @@ describe('cachified', () => {
11921192

11931193
expect(value).toEqual('one');
11941194
expect(onValue).not.toHaveBeenCalled();
1195+
expect(getValues).not.toHaveBeenCalled();
11951196
});
11961197

11971198
it('does not use faulty cache entries', async () => {

src/createBatch.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ export function createBatch<Value, Param>(
5454
}
5555
checkSubmission();
5656
submitted = true;
57+
58+
if (requests.length === 0) {
59+
submission.resolve();
60+
return;
61+
}
62+
5763
try {
5864
const results = await Promise.resolve(
5965
getFreshValues(requests.map(([param]) => param)),

0 commit comments

Comments
 (0)