Skip to content

[JOSS REVIEW] linux-gnu build info is distro specific #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zingale opened this issue Aug 11, 2019 · 3 comments
Closed

[JOSS REVIEW] linux-gnu build info is distro specific #96

zingale opened this issue Aug 11, 2019 · 3 comments
Assignees
@pgrete

Comments

@zingale
Copy link
Contributor

zingale commented Aug 11, 2019

Upon running

make machine-linux-gnu

it outputs:

 *** Execute 'gmake clean' before rebuilding executables ***

   MACHINE: Use apt-get to install libhdf5-serial-dev gfortran openmpi-bin libopenmpi-dev
   MACHINE-NAME: linux-gnu

but many Linux distros do not use apt-get and new users could be confused. It would be helpful to have a list of the requirements needed for Enzo in the README.md or a REQUIREMENTS.txt
@zingale zingale mentioned this issue Aug 11, 2019
Closed
36 tasks
@zingale
Copy link
Contributor Author

zingale commented Aug 16, 2019

JOSS Review: openjournals/joss-reviews#1636

@pgrete pgrete self-assigned this Sep 11, 2019
@pgrete pgrete mentioned this issue Sep 11, 2019
Merged
@bwoshea
Copy link
Contributor

bwoshea commented Sep 13, 2019

@zingale This is addressed in PR #115

@zingale
Copy link
Contributor Author

zingale commented Sep 16, 2019

looks good!

@zingale zingale closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgrete pgrete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zingale @bwoshea @pgrete