Skip to content

[JOSS REVIEW] Hard to learn about AMR capabilities #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zingale opened this issue Aug 11, 2019 · 3 comments
Closed

[JOSS REVIEW] Hard to learn about AMR capabilities #100

zingale opened this issue Aug 11, 2019 · 3 comments
Assignees

Comments

@zingale
Copy link
Contributor

zingale commented Aug 11, 2019

Reading the documentation, I can't find basic information about how the AMR works in Enzo. The main reference is a link to Wikipedia on https://enzo.readthedocs.io/en/enzo-2.6/user_guide/index.html

A natural place would be:

https://enzo.readthedocs.io/en/enzo-2.6/physics/index.html

In particular, it should be easy to find whether Enzo uses something like Berger and Colella AMR (or a subset), an oct-tree block structured AMR (like Flash/Paramesh, e.g.) or cell-by-cell AMR (like Rage). Also, what refinement ratios are supported and whether time subcycling is used. This desciption should be somewhere up front to help potential users understand the capabilities.

@zingale
Copy link
Contributor Author

zingale commented Aug 16, 2019

JOSS Review: openjournals/joss-reviews#1636

@bwoshea
Copy link
Contributor

bwoshea commented Sep 12, 2019

@zingale this is addressed in PR #117 .

@zingale
Copy link
Contributor Author

zingale commented Sep 16, 2019

looks good

@zingale zingale closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants