move out new tests

Author: enyst

tests/unit/test_agent_controller.py

@@ -1,5 +1,5 @@
 import asyncio
-from unittest.mock import ANY, AsyncMock, MagicMock, patch
+from unittest.mock import ANY, AsyncMock, MagicMock
 from uuid import uuid4
 
 import pytest
@@ -833,39 +833,3 @@ def on_event_memory(event: Event):
 
     # Check that the context window exceeded error was raised during the run
     assert step_state.has_errored
-
-
-@pytest.mark.asyncio
-async def test_run_controller_with_memory_error(test_event_stream):
-    config = AppConfig()
-    event_stream = test_event_stream
-
-    agent = MagicMock(spec=Agent)
-    agent.llm = MagicMock(spec=LLM)
-    agent.llm.metrics = Metrics()
-    agent.llm.config = config.get_llm_config()
-
-    runtime = MagicMock(spec=Runtime)
-    runtime.event_stream = event_stream
-
-    # Create a real Memory instance
-    memory = Memory(event_stream=event_stream, sid='test-memory')
-
-    # Patch the _on_recall_action method to raise our test exception
-    def mock_on_recall_action(*args, **kwargs):
-        raise RuntimeError('Test memory error')
-
-    with patch.object(memory, '_on_recall_action', side_effect=mock_on_recall_action):
-        state = await run_controller(
-            config=config,
-            initial_user_action=MessageAction(content='Test message'),
-            runtime=runtime,
-            sid='test',
-            agent=agent,
-            fake_user_response_fn=lambda _: 'repeat',
-            memory=memory,
-        )
-
-    assert state.iteration == 0
-    assert state.agent_state == AgentState.ERROR
-    assert state.last_error == 'Error: RuntimeError'

tests/unit/test_conversation_memory.py

@@ -12,7 +12,6 @@
 )
 from openhands.events.event import Event, EventSource, FileEditSource, FileReadSource
 from openhands.events.observation import CmdOutputObservation
-from openhands.events.observation.agent import RecallObservation, RecallType
 from openhands.events.observation.browse import BrowserOutputObservation
 from openhands.events.observation.commands import (
     CmdOutputMetadata,
@@ -24,7 +23,7 @@
 from openhands.events.observation.reject import UserRejectObservation
 from openhands.events.tool import ToolCallMetadata
 from openhands.memory.conversation_memory import ConversationMemory
-from openhands.utils.prompt import PromptManager, RepositoryInfo, RuntimeInfo
+from openhands.utils.prompt import PromptManager
 
 
 @pytest.fixture
@@ -468,334 +467,3 @@ def test_apply_prompt_caching(conversation_memory):
     assert messages[1].content[0].cache_prompt is False
     assert messages[2].content[0].cache_prompt is False
     assert messages[3].content[0].cache_prompt is True
-
-
-def test_process_events_with_environment_info_recall_observation(conversation_memory):
-    """Test processing a RecallObservation with ENVIRONMENT_INFO type."""
-    obs = RecallObservation(
-        recall_type=RecallType.ENVIRONMENT_INFO,
-        repo_name='test-repo',
-        repo_directory='/path/to/repo',
-        repo_instructions='# Test Repository\nThis is a test repository.',
-        runtime_hosts={'localhost': 8080},
-        content='Recalled environment info',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    assert len(messages) == 2
-    result = messages[1]
-    assert result.role == 'user'
-    assert len(result.content) == 1
-    assert isinstance(result.content[0], TextContent)
-    assert result.content[0].text == 'Formatted repository and runtime info'
-
-    # Verify the prompt_manager was called with the correct parameters
-    conversation_memory.prompt_manager.build_additional_info.assert_called_once()
-    call_args = conversation_memory.prompt_manager.build_additional_info.call_args[1]
-    assert isinstance(call_args['repository_info'], RepositoryInfo)
-    assert call_args['repository_info'].repo_name == 'test-repo'
-    assert call_args['repository_info'].repo_directory == '/path/to/repo'
-    assert isinstance(call_args['runtime_info'], RuntimeInfo)
-    assert call_args['runtime_info'].available_hosts == {'localhost': 8080}
-    assert (
-        call_args['repo_instructions']
-        == '# Test Repository\nThis is a test repository.'
-    )
-
-
-def test_process_events_with_knowledge_microagent_recall_observation(
-    conversation_memory,
-):
-    """Test processing a RecallObservation with KNOWLEDGE_MICROAGENT type."""
-    microagent_knowledge = [
-        {
-            'agent_name': 'test_agent',
-            'trigger_word': 'test',
-            'content': 'This is test agent content',
-        },
-        {
-            'agent_name': 'another_agent',
-            'trigger_word': 'another',
-            'content': 'This is another agent content',
-        },
-        {
-            'agent_name': 'disabled_agent',
-            'trigger_word': 'disabled',
-            'content': 'This is disabled agent content',
-        },
-    ]
-
-    obs = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=microagent_knowledge,
-        content='Recalled knowledge from microagents',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    assert len(messages) == 2
-    result = messages[1]
-    assert result.role == 'user'
-    assert len(result.content) == 1
-    assert isinstance(result.content[0], TextContent)
-    # Verify that disabled_agent is filtered out and enabled agents are included
-    assert 'This is test agent content' in result.content[0].text
-    assert 'This is another agent content' in result.content[0].text
-    assert 'This is disabled agent content' not in result.content[0].text
-
-    # Verify the prompt_manager was called with the correct parameters
-    conversation_memory.prompt_manager.build_microagent_info.assert_called_once()
-    call_args = conversation_memory.prompt_manager.build_microagent_info.call_args[1]
-
-    # Check that disabled_agent was filtered out
-    triggered_agents = call_args['triggered_agents']
-    assert len(triggered_agents) == 2
-    agent_names = [agent['agent_name'] for agent in triggered_agents]
-    assert 'test_agent' in agent_names
-    assert 'another_agent' in agent_names
-    assert 'disabled_agent' not in agent_names
-
-
-def test_process_events_with_recall_observation_extensions_disabled(
-    agent_config, conversation_memory
-):
-    """Test processing a RecallObservation when prompt extensions are disabled."""
-    # Modify the agent config to disable prompt extensions
-    agent_config.enable_prompt_extensions = False
-
-    obs = RecallObservation(
-        recall_type=RecallType.ENVIRONMENT_INFO,
-        repo_name='test-repo',
-        repo_directory='/path/to/repo',
-        content='Recalled environment info',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    # When prompt extensions are disabled, the RecallObservation should be ignored
-    assert len(messages) == 1  # Only the initial system message
-    assert messages[0].role == 'system'
-
-    # Verify the prompt_manager was not called
-    conversation_memory.prompt_manager.build_additional_info.assert_not_called()
-    conversation_memory.prompt_manager.build_microagent_info.assert_not_called()
-
-
-def test_process_events_with_empty_microagent_knowledge(conversation_memory):
-    """Test processing a RecallObservation with empty microagent knowledge."""
-    obs = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[],
-        content='Recalled knowledge from microagents',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    # The implementation returns an empty string but still creates a message
-    assert len(messages) == 2
-    assert messages[0].role == 'system'
-    assert messages[1].role == 'user'
-    assert len(messages[1].content) == 1
-    assert isinstance(messages[1].content[0], TextContent)
-    assert messages[1].content[0].text == ''
-
-    # When there are no triggered agents, build_microagent_info is not called
-    conversation_memory.prompt_manager.build_microagent_info.assert_not_called()
-
-
-def test_process_events_with_recall_observation_deduplication(conversation_memory):
-    """Test that RecallObservations are properly deduplicated based on agent_name."""
-    # Create a sequence of RecallObservations with overlapping agents
-    obs1 = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[
-            {
-                'agent_name': 'python_agent',
-                'trigger_word': 'python',
-                'content': 'Python best practices v1',
-            },
-            {
-                'agent_name': 'git_agent',
-                'trigger_word': 'git',
-                'content': 'Git best practices v1',
-            },
-            {
-                'agent_name': 'image_agent',
-                'trigger_word': 'image',
-                'content': 'Image best practices v1',
-            },
-        ],
-        content='First recall',
-    )
-
-    obs2 = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[
-            {
-                'agent_name': 'python_agent',
-                'trigger_word': 'python',
-                'content': 'Python best practices v2',
-            },
-        ],
-        content='Second recall',
-    )
-
-    obs3 = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[
-            {
-                'agent_name': 'git_agent',
-                'trigger_word': 'git',
-                'content': 'Git best practices v3',
-            },
-        ],
-        content='Third recall',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs1, obs2, obs3],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    # Verify that only the most recent content for each agent is included
-    assert len(messages) == 4  # system + 3 recalls
-    recall_messages = messages[1:]  # Skip system message
-
-    # First recall should only include image_agent (git_agent and python_agent appears later)
-    assert 'Image best practices v1' in recall_messages[0].content[0].text
-    assert 'Git best practices v1' not in recall_messages[0].content[0].text
-    assert 'Python best practices v1' not in recall_messages[0].content[0].text
-
-    # Second recall should include python_agent (it's the most recent for that agent)
-    assert 'Python best practices v2' in recall_messages[1].content[0].text
-
-    # Third recall should include git_agent (it's the most recent for that agent)
-    assert 'Git best practices v3' in recall_messages[2].content[0].text
-
-
-def test_process_events_with_recall_observation_deduplication_disabled_agents(
-    conversation_memory,
-):
-    """Test that disabled agents are filtered out after deduplication."""
-    # Create a sequence of RecallObservations with disabled agents
-    obs1 = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[
-            {
-                'agent_name': 'disabled_agent',
-                'trigger_word': 'disabled',
-                'content': 'Disabled agent content',
-            },
-            {
-                'agent_name': 'enabled_agent',
-                'trigger_word': 'enabled',
-                'content': 'Enabled agent content v1',
-            },
-        ],
-        content='First recall',
-    )
-
-    obs2 = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[
-            {
-                'agent_name': 'enabled_agent',
-                'trigger_word': 'enabled',
-                'content': 'Enabled agent content v2',
-            },
-        ],
-        content='Second recall',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs1, obs2],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    # Verify that disabled agents are filtered out and only the most recent content for enabled agents is included
-    assert len(messages) == 3  # system + 2 recalls
-    recall_messages = messages[1:]  # Skip system message
-
-    # First recall should not include disabled_agent
-    assert 'Disabled agent content' not in recall_messages[0].content[0].text
-    assert (
-        'Enabled agent content v1' not in recall_messages[0].content[0].text
-    )  # Because it appears later
-
-    # Second recall should include enabled_agent (it's the most recent)
-    assert 'Enabled agent content v2' in recall_messages[1].content[0].text
-
-
-def test_process_events_with_recall_observation_deduplication_empty(
-    conversation_memory,
-):
-    """Test that empty RecallObservations are handled correctly."""
-    obs = RecallObservation(
-        recall_type=RecallType.KNOWLEDGE_MICROAGENT,
-        microagent_knowledge=[],
-        content='Empty recall',
-    )
-
-    initial_messages = [
-        Message(role='system', content=[TextContent(text='System message')])
-    ]
-
-    messages = conversation_memory.process_events(
-        condensed_history=[obs],
-        initial_messages=initial_messages,
-        max_message_chars=None,
-        vision_is_active=False,
-    )
-
-    # Verify that empty RecallObservations are handled gracefully
-    assert len(messages) == 2  # system + empty recall
-    assert messages[1].content[0].text == ''  # Empty string for empty recall