Skip to content
This repository was archived by the owner on Nov 6, 2024. It is now read-only.

Commit fdf102a

Browse files
author
Callin Mullaney
committed
feat: run build commands prior to storybook and adjust node version for testing
1 parent 6c617af commit fdf102a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
if: steps.component_changes.outputs.components == 'true'
2121
uses: actions/setup-node@v2
2222
with:
23-
node-version: '16.13'
23+
node-version: '20'
2424
- name: Install dependencies
2525
if: steps.component_changes.outputs.components == 'true'
2626
run: npm ci
@@ -40,7 +40,7 @@ jobs:
4040
- name: Setup Node
4141
uses: actions/setup-node@v2
4242
with:
43-
node-version: '16.13'
43+
node-version: '20'
4444
- name: Install CLI
4545
run: npm install -g @emulsify/cli
4646
- name: Install starter

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
"prettier": "prettier --config config/emulsify-core/prettierrc.config.json --ignore-path config/emulsify-core/.prettierignore --ignore-unknown \"./components/**/*.{js,yml,scss,md}\"",
3737
"prettier-fix": "prettier --config config/emulsify-core/prettierrc.config.json --ignore-path config/emulsify-core/.prettierignore --write --ignore-unknown \"./components**/*.{js,yml,scss,md}\"",
3838
"semantic-release": "semantic-release",
39-
"storybook": "storybook dev -c node_modules/emulsify-core/.storybook --ci -s ../../../dist,../../../assets/images,../../../assets/icons -p 6006",
40-
"storybook-build": "storybook build -c node_modules/emulsify-core/.storybook -s ./dist,./assets/images,./assets/icons -o .out",
39+
"storybook": "npm run build; storybook dev -c node_modules/emulsify-core/.storybook --ci -s ../../../dist,../../../assets/images,../../../assets/icons -p 6006",
40+
"storybook-build": "npm run build; storybook build -c node_modules/emulsify-core/.storybook -s ./dist,./assets/images,./assets/icons -o .out",
4141
"storybook-deploy": "storybook-to-ghpages -o .out",
4242
"test": "jest --coverage --config ./config/jest.config.js",
4343
"twatch": "jest --no-coverage --watch --verbose",

0 commit comments

Comments
 (0)