Fixed passing null is deprecated for htmlspecialchars in Mage_Core_Helper_Abstract (OpenMage#3324)

kyrena · fballiano · kiatng · web-flow · commit b20f5687ef43 · 2023-06-30T08:16:07.000+01:00
Co-authored-by: Fabrizio Balliano &lt;fabrizio.balliano@gmail.com&gt;
Co-authored-by: Ng Kiat Siong &lt;kiatsiong.ng@gmail.com&gt;
diff --git a/app/code/core/Mage/Core/Helper/Abstract.php b/app/code/core/Mage/Core/Helper/Abstract.php
@@ -343,6 +343,9 @@ public function jsQuoteEscape($data, $quote = '\'')
      */
     public function quoteEscape($data, $addSlashes = false)
     {
+        if (!$data) {
+            return $data;
+        }
         if ($addSlashes === true) {
             $data = addslashes($data);
         }

Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,9 @@ public function jsQuoteEscape($data, $quote = '\'')`
`343`	`343`	`*/`
`344`	`344`	`public function quoteEscape($data, $addSlashes = false)`
`345`	`345`	`{`
	`346`	`+ if (!$data) {`
	`347`	`+ return $data;`
	`348`	`+ }`
`346`	`349`	`if ($addSlashes === true) {`
`347`	`350`	`$data = addslashes($data);`
`348`	`351`	`}`