Minor performance improvements (#3244)

romgrk · Andarist · web-flow · commit ad630e33b57a · 2024-08-25T23:27:12.000+02:00
* perf: small lints

* revert

* lint

* chore: add changeset

* Update .changeset/curly-jars-punch.md

---------

Co-authored-by: Mateusz Burzyński &lt;mateuszburzynski@gmail.com&gt;
diff --git a/.changeset/curly-jars-punch.md b/.changeset/curly-jars-punch.md
@@ -0,0 +1,6 @@
+---
+'@emotion/serialize': patch
+'@emotion/utils': patch
+---
+
+Minor performance improvement
diff --git a/packages/serialize/src/index.ts b/packages/serialize/src/index.ts
@@ -365,7 +365,7 @@ function createStringFromObject(
   return string
 }
 
-let labelPattern = /label:\s*([^\s;\n{]+)\s*(;|$)/g
+let labelPattern = /label:\s*([^\s;{]+)\s*(;|$)/g
 
 let sourceMapPattern: RegExp | undefined
 if (isDevelopment) {
diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts
@@ -11,7 +11,7 @@ export function getRegisteredStyles(
   classNames.split(' ').forEach(className => {
     if (registered[className] !== undefined) {
       registeredStyles.push(`${registered[className]};`)
-    } else {
+    } else if (className) {
       rawClassName += `${className} `
     }
   })

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ function createStringFromObject(`
`365`	`365`	`return string`
`366`	`366`	`}`
`367`	`367`
`368`		`-let labelPattern = /label:\s([^\s;\n{]+)\s(;\|$)/g`
	`368`	`+let labelPattern = /label:\s([^\s;{]+)\s(;\|$)/g`
`369`	`369`
`370`	`370`	`let sourceMapPattern: RegExp \| undefined`
`371`	`371`	`if (isDevelopment) {`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export function getRegisteredStyles(`
`11`	`11`	`classNames.split(' ').forEach(className => {`
`12`	`12`	`if (registered[className] !== undefined) {`
`13`	`13`	registeredStyles.push(`${registered[className]};`)
`14`		`- } else {`
	`14`	`+ } else if (className) {`
`15`	`15`	rawClassName += `${className} `
`16`	`16`	`}`
`17`	`17`	`})`