Skip to content

Commit 17fee4b

Browse files
emmatownAndarist
andauthored
Fix some TS things (#2559)
* Point to package root rather than src so that the declarations are used when published, not the src * Don't use as const for unitless * Make tsc pass * Add tsc to CI * Remove type aware linting * Remove ESLint from DTSLint CI job * Newline * Fix more things Co-authored-by: Mateusz Burzyński <[email protected]>
1 parent 4c56bcb commit 17fee4b

File tree

11 files changed

+23
-15
lines changed

11 files changed

+23
-15
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,5 @@ jobs:
222222
- name: Install Dependencies
223223
run: yarn
224224

225-
- name: ESLint
226-
run: yarn lint:check
227225
- name: TypeScript
228226
run: cd packages/${{ matrix.package }} && yarn test:typescript

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,6 @@
9797
"**/packages/**/*.ts",
9898
"**/packages/**/*.tsx"
9999
],
100-
"parserOptions": {
101-
"project": "./tsconfig.json"
102-
},
103100
"rules": {
104101
"prettier/prettier": [
105102
"error",

packages/css/types/index.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1+
/// <reference types="node" />
2+
13
export * from '..'

packages/hash/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { default } from '../src'
1+
export { default } from '..'
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
// TypeScript Version: 2.1
22

3-
export { default } from '../src'
3+
export { default } from '..'

packages/memoize/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { default } from '../src'
1+
export { default } from '..'

packages/sheet/types/index.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
// TypeScript Version: 2.0
22

3-
export * from '../src'
3+
/// <reference types="node" />
4+
5+
export * from '..'

packages/unitless/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
let unitlessKeys = {
1+
let unitlessKeys: Record<string, 1> = {
22
animationIterationCount: 1,
33
borderImageOutset: 1,
44
borderImageSlice: 1,
@@ -46,6 +46,6 @@ let unitlessKeys = {
4646
strokeMiterlimit: 1,
4747
strokeOpacity: 1,
4848
strokeWidth: 1
49-
} as const
49+
}
5050

5151
export default unitlessKeys

packages/utils/types/index.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
// TypeScript Version: 2.2
22

3-
export * from '../src'
3+
/// <reference types="node" />
4+
5+
export * from '..'
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
// TypeScript Version: 2.2
22

3-
export { default } from '../src'
3+
export { default } from '..'

tsconfig.json

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,18 @@
77
"lib": ["es6", "dom"],
88
"module": "commonjs",
99
"noEmit": true,
10+
"skipLibCheck": true,
1011
"skipDefaultLibCheck": true,
1112
"resolveJsonModule": true,
1213
"strict": true,
13-
"target": "es5"
14+
"target": "es5",
15+
"types": []
1416
},
1517
"include": ["packages", "scripts", "site", "test", "playgrounds"],
16-
"exclude": ["node_modules", "packages/*/types/test/*"]
18+
"exclude": [
19+
"node_modules",
20+
"packages/*/types/test/*",
21+
"packages/*/types/test*",
22+
"packages/native"
23+
]
1724
}

0 commit comments

Comments
 (0)