Move egui_plot to its own repo (#4828)

* Part of https://github.com/emilk/egui/issues/4705

`egui_plot` can now be found at https://github.com/emilk/egui_plot

Author: emilk

.github/workflows/labels.yml

@@ -29,4 +29,4 @@ jobs:
         with:
           mode: minimum
           count: 1
-          labels: "CI, dependencies, docs and examples, ecolor, eframe, egui_extras, egui_glow, egui_plot, egui-wgpu, egui-winit, egui, epaint, exclude from changelog, typo"
+          labels: "CI, dependencies, docs and examples, ecolor, eframe, egui_extras, egui_glow, egui-wgpu, egui-winit, egui, epaint, exclude from changelog, typo"

ARCHITECTURE.md

@@ -5,7 +5,7 @@ Also see [`CONTRIBUTING.md`](CONTRIBUTING.md) for what to do before opening a PR
 
 
 ## Crate overview
-The crates in this repository are: `egui, emath, epaint, egui_extras, egui_plot, egui-winit, egui_glow, egui_demo_lib, egui_demo_app`.
+The crates in this repository are: `egui, emath, epaint, egui_extras, egui-winit, egui_glow, egui_demo_lib, egui_demo_app`.
 
 ### `egui`: The main GUI library.
 Example code: `if ui.button("Click me").clicked() { … }`
@@ -24,9 +24,6 @@ Depends on `emath`.
 ### `egui_extras`
 This adds additional features on top of `egui`.
 
-### `egui_plot`
-Plotting for `egui`.
-
 ### `egui-winit`
 This crates provides bindings between [`egui`](https://github.com/emilk/egui) and [winit](https://crates.io/crates/winit).
 

CHANGELOG.md

@@ -1,7 +1,7 @@
 # egui changelog
 All notable changes to the `egui` crate will be documented in this file.
 
-NOTE: this is just the changelog for the core `egui` crate. [`eframe`](crates/eframe/CHANGELOG.md), [`egui_plot`](crates/egui_plot/CHANGELOG.md), [`ecolor`](crates/ecolor/CHANGELOG.md), [`epaint`](crates/epaint/CHANGELOG.md), [`egui-winit`](crates/egui-winit/CHANGELOG.md), [`egui_glow`](crates/egui_glow/CHANGELOG.md) and [`egui-wgpu`](crates/egui-wgpu/CHANGELOG.md) have their own changelogs!
+NOTE: this is just the changelog for the core `egui` crate. [`eframe`](crates/eframe/CHANGELOG.md), [`ecolor`](crates/ecolor/CHANGELOG.md), [`epaint`](crates/epaint/CHANGELOG.md), [`egui-winit`](crates/egui-winit/CHANGELOG.md), [`egui_glow`](crates/egui_glow/CHANGELOG.md) and [`egui-wgpu`](crates/egui-wgpu/CHANGELOG.md) have their own changelogs!
 
 This file is updated upon each release.
 Changes since the last release can be found at <https://github.com/emilk/egui/compare/latest...HEAD> or by running the `scripts/generate_changelog.py` script.

CODEOWNERS

@@ -1,2 +1 @@
-/crates/egui_plot @Bromeon @EmbersArc
 /crates/egui-wgpu @Wumpf

Cargo.lock

@@ -1059,15 +1059,6 @@ dependencies = [
  "env_logger",
 ]
 
-[[package]]
-name = "custom_plot_manipulation"
-version = "0.1.0"
-dependencies = [
- "eframe",
- "egui_plot",
- "env_logger",
-]
-
 [[package]]
 name = "custom_window_frame"
 version = "0.1.0"
@@ -1302,7 +1293,6 @@ dependencies = [
  "document-features",
  "egui",
  "egui_extras",
- "egui_plot",
  "log",
  "serde",
  "unicode_names2",
@@ -1348,17 +1338,6 @@ dependencies = [
  "winit",
 ]
 
-[[package]]
-name = "egui_plot"
-version = "0.28.1"
-dependencies = [
- "ahash",
- "document-features",
- "egui",
- "emath",
- "serde",
-]
-
 [[package]]
 name = "ehttp"
 version = "0.5.0"
@@ -3288,17 +3267,6 @@ dependencies = [
  "winapi-util",
 ]
 
-[[package]]
-name = "save_plot"
-version = "0.1.0"
-dependencies = [
- "eframe",
- "egui_plot",
- "env_logger",
- "image",
- "rfd",
-]
-
 [[package]]
 name = "scoped-tls"
 version = "1.0.1"

Cargo.toml

@@ -6,7 +6,6 @@ members = [
     "crates/egui_demo_lib",
     "crates/egui_extras",
     "crates/egui_glow",
-    "crates/egui_plot",
     "crates/egui-wgpu",
     "crates/egui-winit",
     "crates/egui",
@@ -58,7 +57,6 @@ emath = { version = "0.28.1", path = "crates/emath", default-features = false }
 ecolor = { version = "0.28.1", path = "crates/ecolor", default-features = false }
 epaint = { version = "0.28.1", path = "crates/epaint", default-features = false }
 egui = { version = "0.28.1", path = "crates/egui", default-features = false }
-egui_plot = { version = "0.28.1", path = "crates/egui_plot", default-features = false }
 egui-winit = { version = "0.28.1", path = "crates/egui-winit", default-features = false }
 egui_extras = { version = "0.28.1", path = "crates/egui_extras", default-features = false }
 egui-wgpu = { version = "0.28.1", path = "crates/egui-wgpu", default-features = false }

RELEASES.md

@@ -44,6 +44,7 @@ We don't update the MSRV in a patch release, unless we really, really need to.
   - check the in-browser profiler
 * [ ] check the color test
 * [ ] update `eframe_template` and test
+* [ ] update `egui_plot` and test
 * [ ] update `egui_tiles` and test
 * [ ] test with Rerun
 * [ ] `./scripts/check.sh`
@@ -76,7 +77,6 @@ I usually do this all on the `master` branch, but doing it in a release branch i
 (cd crates/ecolor        && cargo publish --quiet)  &&  echo "✅ ecolor"
 (cd crates/epaint        && cargo publish --quiet)  &&  echo "✅ epaint"
 (cd crates/egui          && cargo publish --quiet)  &&  echo "✅ egui"
-(cd crates/egui_plot     && cargo publish --quiet)  &&  echo "✅ egui_plot"
 (cd crates/egui-winit    && cargo publish --quiet)  &&  echo "✅ egui-winit"
 (cd crates/egui_extras   && cargo publish --quiet)  &&  echo "✅ egui_extras"
 (cd crates/egui-wgpu     && cargo publish --quiet)  &&  echo "✅ egui-wgpu"
@@ -94,4 +94,5 @@ I usually do this all on the `master` branch, but doing it in a release branch i
 
 ## After release
 * [ ] publish new `eframe_template`
+* [ ] publish new `egui_plot`
 * [ ] publish new `egui_tiles`

crates/egui_demo_lib/Cargo.toml

@@ -34,7 +34,7 @@ default = []
 chrono = ["egui_extras/datepicker", "dep:chrono"]
 
 ## Allow serialization using [`serde`](https://docs.rs/serde).
-serde = ["egui/serde", "egui_plot/serde", "dep:serde", "egui_extras/serde"]
+serde = ["egui/serde", "dep:serde", "egui_extras/serde"]
 
 ## Enable better syntax highlighting using [`syntect`](https://docs.rs/syntect).
 syntect = ["egui_extras/syntect"]
@@ -43,7 +43,6 @@ syntect = ["egui_extras/syntect"]
 [dependencies]
 egui = { workspace = true, default-features = false, features = ["color-hex"] }
 egui_extras = { workspace = true, features = ["default"] }
-egui_plot = { workspace = true, features = ["default"] }
 
 log.workspace = true
 unicode_names2 = { version = "0.6.0", default-features = false } # this old version has fewer dependencies

crates/egui_demo_lib/src/demo/context_menu.rs

@@ -1,51 +1,6 @@
-use egui::Vec2b;
-
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Default, PartialEq, Eq)]
 #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
-enum Plot {
-    Sin,
-    Bell,
-    Sigmoid,
-}
-
-fn gaussian(x: f64) -> f64 {
-    let var: f64 = 2.0;
-    f64::exp(-(x / var).powi(2)) / (var * f64::sqrt(std::f64::consts::TAU))
-}
-
-fn sigmoid(x: f64) -> f64 {
-    -1.0 + 2.0 / (1.0 + f64::exp(-x))
-}
-
-#[derive(Clone, PartialEq)]
-#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
-pub struct ContextMenus {
-    plot: Plot,
-    show_axes: Vec2b,
-    allow_drag: bool,
-    allow_zoom: bool,
-    allow_scroll: bool,
-    center_x_axis: bool,
-    center_y_axis: bool,
-    width: f32,
-    height: f32,
-}
-
-impl Default for ContextMenus {
-    fn default() -> Self {
-        Self {
-            plot: Plot::Sin,
-            show_axes: Vec2b::TRUE,
-            allow_drag: true,
-            allow_zoom: true,
-            allow_scroll: true,
-            center_x_axis: false,
-            center_y_axis: false,
-            width: 400.0,
-            height: 200.0,
-        }
-    }
-}
+pub struct ContextMenus {}
 
 impl crate::Demo for ContextMenus {
     fn name(&self) -> &'static str {
@@ -66,95 +21,24 @@ impl crate::View for ContextMenus {
     fn ui(&mut self, ui: &mut egui::Ui) {
         ui.horizontal(|ui| {
             ui.menu_button("Click for menu", Self::nested_menus);
+
             ui.button("Right-click for menu")
                 .context_menu(Self::nested_menus);
+
             if ui.ctx().is_context_menu_open() {
                 ui.label("Context menu is open");
             } else {
                 ui.label("Context menu is closed");
             }
         });
 
-        ui.separator();
-
-        ui.label("Right-click plot to edit it!");
-        ui.horizontal(|ui| {
-            self.example_plot(ui).context_menu(|ui| {
-                ui.menu_button("Plot", |ui| {
-                    if ui.radio_value(&mut self.plot, Plot::Sin, "Sin").clicked()
-                        || ui
-                            .radio_value(&mut self.plot, Plot::Bell, "Gaussian")
-                            .clicked()
-                        || ui
-                            .radio_value(&mut self.plot, Plot::Sigmoid, "Sigmoid")
-                            .clicked()
-                    {
-                        ui.close_menu();
-                    }
-                });
-                egui::Grid::new("button_grid").show(ui, |ui| {
-                    ui.add(
-                        egui::DragValue::new(&mut self.width)
-                            .range(0.0..=f32::INFINITY)
-                            .speed(1.0)
-                            .prefix("Width: "),
-                    );
-                    ui.add(
-                        egui::DragValue::new(&mut self.height)
-                            .range(0.0..=f32::INFINITY)
-                            .speed(1.0)
-                            .prefix("Height: "),
-                    );
-                    ui.end_row();
-                    ui.checkbox(&mut self.show_axes[0], "x-Axis");
-                    ui.checkbox(&mut self.show_axes[1], "y-Axis");
-                    ui.end_row();
-                    if ui.checkbox(&mut self.allow_drag, "Drag").changed()
-                        || ui.checkbox(&mut self.allow_zoom, "Zoom").changed()
-                        || ui.checkbox(&mut self.allow_scroll, "Scroll").changed()
-                    {
-                        ui.close_menu();
-                    }
-                });
-            });
-        });
         ui.vertical_centered(|ui| {
             ui.add(crate::egui_github_link_file!());
         });
     }
 }
 
 impl ContextMenus {
-    fn example_plot(&self, ui: &mut egui::Ui) -> egui::Response {
-        use egui_plot::{Line, PlotPoints};
-        let n = 128;
-        let line = Line::new(
-            (0..=n)
-                .map(|i| {
-                    use std::f64::consts::TAU;
-                    let x = egui::remap(i as f64, 0.0..=n as f64, -TAU..=TAU);
-                    match self.plot {
-                        Plot::Sin => [x, x.sin()],
-                        Plot::Bell => [x, 10.0 * gaussian(x)],
-                        Plot::Sigmoid => [x, sigmoid(x)],
-                    }
-                })
-                .collect::<PlotPoints>(),
-        );
-        egui_plot::Plot::new("example_plot")
-            .show_axes(self.show_axes)
-            .allow_drag(self.allow_drag)
-            .allow_zoom(self.allow_zoom)
-            .allow_scroll(self.allow_scroll)
-            .center_x_axis(self.center_x_axis)
-            .center_x_axis(self.center_y_axis)
-            .width(self.width)
-            .height(self.height)
-            .data_aspect(1.0)
-            .show(ui, |plot_ui| plot_ui.line(line))
-            .response
-    }
-
     fn nested_menus(ui: &mut egui::Ui) {
         ui.set_max_width(200.0); // To make sure we wrap long text
 

crates/egui_demo_lib/src/demo/demo_app_windows.rs

@@ -36,7 +36,6 @@ impl Default for Demos {
             Box::<super::painting::Painting>::default(),
             Box::<super::pan_zoom::PanZoom>::default(),
             Box::<super::panels::Panels>::default(),
-            Box::<super::plot_demo::PlotDemo>::default(),
             Box::<super::scrolling::Scrolling>::default(),
             Box::<super::sliders::Sliders>::default(),
             Box::<super::strip_demo::StripDemo>::default(),

crates/egui_demo_lib/src/demo/mod.rs

@@ -22,7 +22,6 @@ pub mod painting;
 pub mod pan_zoom;
 pub mod panels;
 pub mod password;
-pub mod plot_demo;
 pub mod scrolling;
 pub mod sliders;
 pub mod strip_demo;