File tree Expand file tree Collapse file tree 1 file changed +38
-0
lines changed Expand file tree Collapse file tree 1 file changed +38
-0
lines changed Original file line number Diff line number Diff line change
1
+ - Start Date: 2016-04-16
2
+ - RFC PR: (leave this empty)
3
+ - Ember Issue: (leave this empty)
4
+
5
+ # Summary
6
+
7
+ [ ` contains ` ] ( http://emberjs.com/api/classes/Ember.Array.html#method_contains ) is
8
+ implemented on ` Ember.Array ` , but [ contains was renamed to includes in 2014]
9
+ (https://github.com/tc39/Array.prototype.includes/commit/4b6b9534582cb7991daea3980c26a34af0e76c6c )
10
+ - this proposal is for ` contains ` to be deprecated in favour of an ` includes `
11
+ method on ` Ember.Array `
12
+
13
+ # Motivation
14
+
15
+ Motivation is to stay in line with web standards
16
+
17
+ # Detailed design
18
+
19
+ * Rename ` contains ` method to ` includes `
20
+ * Alias ` contains ` with deprecation warning, deprecate in line with standard
21
+ deprecation process
22
+
23
+ # How We Teach This
24
+
25
+ Update any references in docs and guides to ` includes `
26
+
27
+ # Drawbacks
28
+
29
+ * May break existing apps
30
+ * [ Was considered before but was too early] ( https://github.com/emberjs/ember.js/issues/5670#issuecomment-64084814 )
31
+
32
+ # Alternatives
33
+
34
+ Keep current methods
35
+
36
+ # Unresolved questions
37
+
38
+ None
You can’t perform that action at this time.
0 commit comments