Skip to content

Commit fbd8612

Browse files
committed
Make rule not recommended
1 parent 0e5d7d5 commit fbd8612

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ rules in templates can be disabled with eslint directives with mustache or html
180180
| :------------------------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------------------- | :- | :- | :- |
181181
| [no-attrs-in-components](docs/rules/no-attrs-in-components.md) | disallow usage of `this.attrs` in components || | |
182182
| [no-attrs-snapshot](docs/rules/no-attrs-snapshot.md) | disallow use of attrs snapshot in the `didReceiveAttrs` and `didUpdateAttrs` component hooks || | |
183-
| [no-builtin-form-components](docs/rules/no-builtin-form-components.md) | disallow usage of built-in form components | | | |
183+
| [no-builtin-form-components](docs/rules/no-builtin-form-components.md) | disallow usage of built-in form components | | | |
184184
| [no-classic-components](docs/rules/no-classic-components.md) | enforce using Glimmer components || | |
185185
| [no-component-lifecycle-hooks](docs/rules/no-component-lifecycle-hooks.md) | disallow usage of "classic" ember component lifecycle hooks. Render modifiers or custom functional modifiers should be used instead. || | |
186186
| [no-on-calls-in-components](docs/rules/no-on-calls-in-components.md) | disallow usage of `on` to call lifecycle hooks in components || | |

docs/rules/no-builtin-form-components.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# ember/no-builtin-form-components
22

3-
💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations).
4-
53
<!-- end auto-generated rule header -->
64

75
This rule disallows the use of Ember's built-in form components (`Input` and `Textarea`) from `@ember/component` and encourages using native HTML elements instead.

lib/recommended-rules.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ module.exports = {
1818
"ember/no-at-ember-render-modifiers": "error",
1919
"ember/no-attrs-in-components": "error",
2020
"ember/no-attrs-snapshot": "error",
21-
"ember/no-builtin-form-components": "error",
2221
"ember/no-capital-letters-in-routes": "error",
2322
"ember/no-classic-classes": "error",
2423
"ember/no-classic-components": "error",

lib/rules/no-builtin-form-components.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = {
1212
docs: {
1313
description: 'disallow usage of built-in form components',
1414
category: 'Components',
15-
recommended: true,
15+
recommended: false,
1616
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-builtin-form-components.md',
1717
},
1818
fixable: null,

0 commit comments

Comments
 (0)