Skip to content

Commit b19a016

Browse files
authored
Allow imports from ember-data/store (#2162)
This adjusts the `use-ember-data-rfc-395` rule so imports from `ember-data/store` are allowed. It is a valid import according to the deprecation guides: https://deprecations.emberjs.com/id/ember-data-deprecate-legacy-imports/
1 parent 367a439 commit b19a016

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lib/rules/use-ember-data-rfc-395-imports.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@ module.exports = {
9696
* into `import { attr } from "@ember-data/attr"`
9797
*/
9898
ImportDeclaration(node) {
99+
// 'ember-data/store' is a valid import again: https://deprecations.emberjs.com/id/ember-data-deprecate-legacy-imports/
100+
if (node.source.value === 'ember-data/store') {
101+
return;
102+
}
103+
99104
if (node.source.value in OLD_DATA_IMPORTS) {
100105
const fix = buildFix(node, OLD_DATA_IMPORTS);
101106
context.report({ node, message, fix });

tests/lib/rules/use-ember-data-rfc-395-imports.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ ruleTester.run('use-ember-data-rfc-395-imports', rule, {
4444
"import ModelRegistry from 'ember-data/types/registries/model';",
4545
"import SerializerRegistry from 'ember-data/types/registries/serializer';",
4646
"import TransformRegistry from 'ember-data/types/registries/transform';",
47+
"import Store from 'ember-data/store';",
4748
],
4849

4950
invalid: [

0 commit comments

Comments
 (0)