Skip to content
This repository was archived by the owner on Feb 6, 2021. It is now read-only.

Commit 55ac7b1

Browse files
authored
Merge pull request #156 from rwjblue/bring-back-bower-support
Bring back Ember < 2.12 support.
2 parents 009b8f4 + 7466a60 commit 55ac7b1

File tree

7 files changed

+73
-1
lines changed

7 files changed

+73
-1
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,5 @@
1919
# ember-try
2020
/.node_modules.ember-try/
2121
/package.json.ember-try
22+
/bower.json
23+
/bower_components/

.npmignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
/tests/
1818
/yarn.lock
1919
.gitkeep
20+
bower.json
21+
/bower_components/
2022

2123
# ember-try
2224
/.node_modules.ember-try/

.travis.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ env:
1919
matrix:
2020
# we recommend new addons test the current and previous LTS
2121
# as well as latest stable release (bonus points to beta/canary)
22+
- EMBER_TRY_SCENARIO=ember-1.13
23+
- EMBER_TRY_SCENARIO=ember-lts-2.4
24+
- EMBER_TRY_SCENARIO=ember-lts-2.8
2225
- EMBER_TRY_SCENARIO=ember-lts-2.12
2326
- EMBER_TRY_SCENARIO=ember-lts-2.16
2427
- EMBER_TRY_SCENARIO=ember-lts-2.18

config/ember-try.js

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,65 @@ module.exports = function() {
1111
return {
1212
useYarn: true,
1313
scenarios: [
14+
{
15+
name: 'ember-1.13',
16+
env: {
17+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
18+
},
19+
bower: {
20+
dependencies: {
21+
ember: '~1.13.0',
22+
},
23+
},
24+
npm: {
25+
devDependencies: {
26+
'@ember/jquery': '^0.5.1',
27+
'ember-source': null,
28+
'jquery': '^2.2.4',
29+
},
30+
},
31+
},
32+
{
33+
name: 'ember-lts-2.4',
34+
env: {
35+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
36+
},
37+
bower: {
38+
dependencies: {
39+
ember: 'components/ember#lts-2-4',
40+
},
41+
resolutions: {
42+
ember: 'lts-2-4',
43+
},
44+
},
45+
npm: {
46+
devDependencies: {
47+
'@ember/jquery': '^0.5.1',
48+
'ember-source': null,
49+
'jquery': '^2.2.4',
50+
},
51+
},
52+
},
53+
{
54+
name: 'ember-lts-2.8',
55+
env: {
56+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
57+
},
58+
bower: {
59+
dependencies: {
60+
ember: 'components/ember#lts-2-8',
61+
},
62+
resolutions: {
63+
ember: 'lts-2-8',
64+
},
65+
},
66+
npm: {
67+
devDependencies: {
68+
'@ember/jquery': '^0.5.1',
69+
'ember-source': null,
70+
},
71+
},
72+
},
1473
{
1574
name: 'ember-lts-2.12',
1675
env: {

index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@ module.exports = {
142142
let ember = this.project.findAddonByName('ember-source');
143143
if (ember) {
144144
return ember.absolutePaths.templateCompiler;
145+
} else if (!templateCompilerPath) {
146+
templateCompilerPath = this.project.bowerDirectory + '/ember/ember-template-compiler';
145147
}
146148

147149
return path.resolve(this.project.root, templateCompilerPath);

node-tests/test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ describe('included()', function() {
6969
let registry;
7070
let expectedRequireFilePath = path.resolve(__dirname, '../lib/require-from-worker');
7171
let expectedTemplateCompilerPath = path.resolve(__dirname, '../node_modules/ember-source/dist/ember-template-compiler.js');
72+
if (!fs.existsSync(expectedTemplateCompilerPath)) {
73+
expectedTemplateCompilerPath = path.resolve(__dirname, '../bower_components/ember/ember-template-compiler.js');
74+
}
7275
let templateCompilerContents = fs.readFileSync(`${expectedTemplateCompilerPath}`, { encoding: 'utf-8' });
7376
let testBaseDir = () => path.resolve(__dirname, '..');
7477
let FixtureBaseDir = () => path.resolve(__dirname, './fixtures');

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@
7171
},
7272
"resolutions": {
7373
"ember-cli-qunit/qunit": "~2.6.0",
74-
"ember-cli-broccoli-sane-watcher": "~2.1.0"
74+
"ember-cli-broccoli-sane-watcher": "~2.1.0",
75+
"**/ember-cli-htmlbars-inline-precompile": "^1.0.5"
7576
},
7677
"ember-addon": {
7778
"configPath": "tests/dummy/config",

0 commit comments

Comments
 (0)