Skip to content

Commit 0d1b5e0

Browse files
legendofmiracleselkowar
authored andcommitted
Checks if window is open to not flicker the window
1 parent 6867010 commit 0d1b5e0

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

crates/eww/src/app.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,14 @@ impl App {
139139
sender.respond_with_error_list(errors)?;
140140
}
141141
DaemonCommand::OpenWindow { window_name, pos, size, anchor, screen: monitor, should_toggle, sender } => {
142-
let result = if should_toggle && self.open_windows.contains_key(&window_name) {
143-
self.close_window(&window_name)
142+
let is_open = self.open_windows.contains_key(&window_name);
143+
let result = if is_open {
144+
if should_toggle {
145+
self.close_window(&window_name)
146+
} else {
147+
// user should use `eww reload` to reload windows (https://github.com/elkowar/eww/issues/260)
148+
Ok(())
149+
}
144150
} else {
145151
self.open_window(&window_name, pos, size, monitor, anchor)
146152
};

0 commit comments

Comments
 (0)