Skip to content

Bug: File extension filter erroneously flags files that have more than dot (.) character in file name. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcG2 opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : implemented Feature was implemented in difPy.

Comments

@MarcG2
Copy link

MarcG2 commented Sep 15, 2023

I'm running difPy via CLI and when I looked at the stats JSON file, I noticed it was flagging a bunch valid files. Specifically it says
"ImageFilterWarning: invalid image extension."

An example file name that gets flagged is
img test 10.5 sample 5.png

I'm guessing the extension filter doesn't account for files that have dot (.) characters in the middle of the file name.

@MarcG2 MarcG2 changed the title File extension filter erroneously flags files that have more than dot (.) character in file name. Bug: File extension filter erroneously flags files that have more than dot (.) character in file name. Sep 15, 2023
@elisemercury
Copy link
Owner

Hi @MarcG2 ,

Thanks for flagging this! Indeed, assumes that there are no dots present in the filename, hence they are marked as invalid. This will be fixed in the next DiPy update!

Thanks again and best,
Elise

@elisemercury elisemercury added bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : in progress Feature is currently being implemented in difPy. labels Sep 26, 2023
@elisemercury elisemercury self-assigned this Sep 26, 2023
@elisemercury elisemercury added status : implemented Feature was implemented in difPy. and removed status : in progress Feature is currently being implemented in difPy. labels Sep 27, 2023
@elisemercury
Copy link
Owner

Hi @MarcG2,

This issue has been fixed with difPy v4.0.1. Thanks again for flagging this!

Best,
Elise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug : non-critical A bug was found in difPy, but it is not critical to the functioning of the package. status : implemented Feature was implemented in difPy.
Projects
None yet
Development

No branches or pull requests

2 participants