Skip to content

Commit c3ba5ee

Browse files
committed
Avoid repeatedly extracting log tag from class name in runtime
1 parent 7c8964a commit c3ba5ee

File tree

1 file changed

+22
-20
lines changed

1 file changed

+22
-20
lines changed

app/src/main/java/ai/elimu/content_provider/ui/letter_sound/LetterSoundsFragment.kt

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,14 @@ class LetterSoundsFragment : Fragment() {
3131

3232
private var textView: TextView? = null
3333

34+
private val TAG = javaClass.name
35+
3436
override fun onCreateView(
3537
inflater: LayoutInflater,
3638
container: ViewGroup?,
3739
savedInstanceState: Bundle?
3840
): View? {
39-
Log.i(javaClass.name, "onCreateView")
41+
Log.i(TAG, "onCreateView")
4042

4143
letterSoundsViewModel = ViewModelProvider(this).get(
4244
LetterSoundsViewModel::class.java
@@ -46,15 +48,15 @@ class LetterSoundsFragment : Fragment() {
4648
textView = root.findViewById(R.id.text_letter_sounds) as? TextView
4749
letterSoundsViewModel!!.text.observe(viewLifecycleOwner, object : Observer<String?> {
4850
override fun onChanged(s: String?) {
49-
Log.i(javaClass.name, "onChanged")
51+
Log.i(TAG, "onChanged")
5052
textView?.text = s
5153
}
5254
})
5355
return root
5456
}
5557

5658
override fun onStart() {
57-
Log.i(javaClass.name, "onStart")
59+
Log.i(TAG, "onStart")
5860
super.onStart()
5961

6062
// Download LetterSounds from REST API, and store them in the database
@@ -64,18 +66,18 @@ class LetterSoundsFragment : Fragment() {
6466
LetterSoundsService::class.java
6567
)
6668
val letterSoundGsonsCall = letterSoundsService.listLetterSounds()
67-
Log.i(javaClass.name, "letterSoundGsonsCall.request(): " + letterSoundGsonsCall.request())
69+
Log.i(TAG, "letterSoundGsonsCall.request(): " + letterSoundGsonsCall.request())
6870
letterSoundGsonsCall.enqueue(object : Callback<List<LetterSoundGson>> {
6971
override fun onResponse(
7072
call: Call<List<LetterSoundGson>>,
7173
response: Response<List<LetterSoundGson>>
7274
) {
73-
Log.i(javaClass.name, "onResponse")
75+
Log.i(TAG, "onResponse")
7476

75-
Log.i(javaClass.name, "response: $response")
77+
Log.i(TAG, "response: $response")
7678
if (response.isSuccessful) {
7779
val letterSoundGsons = response.body()!!
78-
Log.i(javaClass.name, "letterSoundGsons.size(): " + letterSoundGsons.size)
80+
Log.i(TAG, "letterSoundGsons.size(): " + letterSoundGsons.size)
7981

8082
if (letterSoundGsons.size > 0) {
8183
processResponseBody(letterSoundGsons)
@@ -90,9 +92,9 @@ class LetterSoundsFragment : Fragment() {
9092
}
9193

9294
override fun onFailure(call: Call<List<LetterSoundGson>>, t: Throwable) {
93-
Log.e(javaClass.name, "onFailure", t)
95+
Log.e(TAG, "onFailure", t)
9496

95-
Log.e(javaClass.name, "t.getCause():", t.cause)
97+
Log.e(TAG, "t.getCause():", t.cause)
9698

9799
// Handle error
98100
Snackbar.make(textView!!, t.cause.toString(), Snackbar.LENGTH_LONG)
@@ -104,12 +106,12 @@ class LetterSoundsFragment : Fragment() {
104106
}
105107

106108
private fun processResponseBody(letterSoundGsons: List<LetterSoundGson>) {
107-
Log.i(javaClass.name, "processResponseBody")
109+
Log.i(TAG, "processResponseBody")
108110

109111
val executorService = Executors.newSingleThreadExecutor()
110112
executorService.execute(object : Runnable {
111113
override fun run() {
112-
Log.i(javaClass.name, "run")
114+
Log.i(TAG, "run")
113115

114116
val roomDb = RoomDb.getDatabase(context)
115117
val letterSoundDao = roomDb.letterSoundDao()
@@ -122,50 +124,50 @@ class LetterSoundsFragment : Fragment() {
122124
letterSoundDao.deleteAll()
123125

124126
for (letterSoundGson in letterSoundGsons) {
125-
Log.i(javaClass.name, "letterSoundGson.getId(): " + letterSoundGson.id)
127+
Log.i(TAG, "letterSoundGson.getId(): " + letterSoundGson.id)
126128

127129
// Store the LetterSound in the database
128130
val letterSound = GsonToRoomConverter.getLetterSound(letterSoundGson)
129131
letterSoundDao.insert(letterSound)
130132
Log.i(
131-
javaClass.name,
133+
TAG,
132134
"Stored LetterSound in database with ID " + letterSound.id
133135
)
134136

135137
// Store all the LetterSound's letters in the database
136138
val letterGsons = letterSoundGson.letters
137-
Log.i(javaClass.name, "letterGsons.size(): " + letterGsons.size)
139+
Log.i(TAG, "letterGsons.size(): " + letterGsons.size)
138140
for (letterGson in letterGsons) {
139-
Log.i(javaClass.name, "letterGson.getId(): " + letterGson.id)
141+
Log.i(TAG, "letterGson.getId(): " + letterGson.id)
140142
val letterSound_Letter = LetterSound_Letter()
141143
letterSound_Letter.letterSound_id = letterSoundGson.id
142144
letterSound_Letter.letters_id = letterGson.id
143145
letterSound_LetterDao.insert(letterSound_Letter)
144146
Log.i(
145-
javaClass.name,
147+
TAG,
146148
"Stored LetterSound_Letter in database. LetterSound_id: " + letterSound_Letter.letterSound_id + ", letters_id: " + letterSound_Letter.letters_id
147149
)
148150
}
149151

150152
// Store all the LetterSound's sounds in the database
151153
val soundGsons = letterSoundGson.sounds
152-
Log.i(javaClass.name, "soundGsons.size():" + soundGsons.size)
154+
Log.i(TAG, "soundGsons.size():" + soundGsons.size)
153155
for (soundGson in soundGsons) {
154-
Log.i(javaClass.name, "soundGson.getId(): " + soundGson.id)
156+
Log.i(TAG, "soundGson.getId(): " + soundGson.id)
155157
val letterSound_Sound = LetterSound_Sound()
156158
letterSound_Sound.letterSound_id = letterSoundGson.id
157159
letterSound_Sound.sounds_id = soundGson.id
158160
letterSound_SoundDao.insert(letterSound_Sound)
159161
Log.i(
160-
javaClass.name,
162+
TAG,
161163
"Stored LetterSound_Sound in database. LetterSound_id: " + letterSound_Sound.letterSound_id + ", sounds_id: " + letterSound_Sound.sounds_id
162164
)
163165
}
164166
}
165167

166168
// Update the UI
167169
val letterSounds = letterSoundDao.loadAll()
168-
Log.i(javaClass.name, "letterSounds.size(): " + letterSounds.size)
170+
Log.i(TAG, "letterSounds.size(): " + letterSounds.size)
169171
activity!!.runOnUiThread {
170172
textView!!.text = "letterSounds.size(): " + letterSounds.size
171173
Snackbar.make(

0 commit comments

Comments
 (0)