Skip to content

Remove newline from final bullet point of PR template #18419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented May 9, 2025

To avoid the line being broken in the template:

image

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

To avoid the line being broken in the template.
@anoadragon453 anoadragon453 marked this pull request as ready for review May 9, 2025 14:43
@anoadragon453 anoadragon453 requested a review from a team as a code owner May 9, 2025 14:43
@anoadragon453 anoadragon453 merged commit 480d4fa into develop May 13, 2025
31 checks passed
@anoadragon453 anoadragon453 deleted the anoa/pr_template_newline branch May 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants