Skip to content

Explicitly enable pypy for cibuildwheel #18417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Explicitly enable pypy for cibuildwheel #18417

merged 3 commits into from
May 13, 2025

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented May 9, 2025 •
edited
Loading

Otherwise pypy builds will be disabled after the upgrade to cibuildwheel v3:

Warning: PyPy builds will be disabled by default in version 3. Enabling PyPy builds should be specified by enable

Fixes #18215

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453 anoadragon453 marked this pull request as ready for review May 9, 2025 14:20
@anoadragon453 anoadragon453 requested a review from a team as a code owner May 9, 2025 14:20
@anoadragon453
Explicitly enable pypy for cibuildwheel
c30b414 
Otherwise pypy builds will be disabled after the upgrade to cibuildwheel
v3:

> Warning: PyPy builds will be disabled by default in version 3. Enabling
PyPy builds should be specified by enable
@anoadragon453
newsfile
75b6cf4
@anoadragon453 anoadragon453 force-pushed the anoa/cibw_enable_pypy branch from ba206de to 892dd26 Compare May 12, 2025 16:29
@anoadragon453 anoadragon453 marked this pull request as draft May 12, 2025 17:26
@anoadragon453 anoadragon453 force-pushed the anoa/cibw_enable_pypy branch from 892dd26 to 456ee7f Compare May 13, 2025 11:50
@anoadragon453 anoadragon453 marked this pull request as ready for review May 13, 2025 12:32
erikjohnston
erikjohnston approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the poetry.lock change is spurious?

@anoadragon453
Copy link
Member Author

anoadragon453 commented May 13, 2025 •
edited
Loading

Looks like the poetry.lock change is spurious?

You'd hope, but poetry will actually error if the lockfile isn't regenerated, see:

https://github.com/element-hq/synapse/actions/runs/14931031372/job/41947086455?pr=18417#step:3:107

...I'm not actually sure how it calculates that without updating a hash somewhere. But it was needed to make CI happy.

Edit: perhaps it's using a cache in CI.

@anoadragon453 anoadragon453 merged commit 2db54c8 into develop May 13, 2025
40 checks passed
@anoadragon453 anoadragon453 deleted the anoa/cibw_enable_pypy branch May 13, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cibuildwheel — PyPy builds will be disabled by default in version 3
2 participants
@anoadragon453 @erikjohnston