Allow a few admin APIs used by MAS to run on workers #18313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
force-pushed
the
quenting/morg-mas-fixes
branch
from
4a6639b to
03d716e
Compare
reivilibre
reviewed
Apr 7, 2025
synapse/handlers/set_password.py
Outdated
Comment on lines
58
to
59
| # If the device_handler is None, then password changing is disabled. | ||
| if self._device_handler is None: |
There was a problem hiding this comment.
no problem for a rollout, but for merging to mainline I worry if clarity suffers a bit with this indirection? but should think about it later
There was a problem hiding this comment.
Ah - I see why this was done.
We could go back to the previous check on can_change_password but then we still need to deal with checking if _device_handler is None.
Maybe it's better to combine the two?
ie.
if not self._auth_handler.can_change_password() or self._device_handler is None:That would keep the clarity here and negate the need for the comment.
Thoughts?
There was a problem hiding this comment.
I did something like that in fcccca4
devonh
reviewed
Apr 15, 2025
sandhose
force-pushed
the
quenting/morg-mas-fixes
branch
from
c5cd804 to
ccd3b30
Compare
anoadragon453
approved these changes
May 2, 2025
There was a problem hiding this comment.
Oh, and can you update the worker documentation with the newly-allowed endpoints, please?
…e RegistrationWokerStore.
…ord changing is disabled
Co-authored-by: Devon Hudson <[email protected]>
Co-authored-by: Andrew Morgan <[email protected]>
sandhose
force-pushed
the
quenting/morg-mas-fixes
branch
from
c46853a to
842b8cf
Compare
anoadragon453
approved these changes
May 2, 2025
MatMaul
pushed a commit
to tchapgouv/synapse
that referenced
this pull request
May 12, 2025
This should be reviewed commit by commit. It adds a few admin servlets that are used by MAS when in delegation mode to workers --------- Co-authored-by: Olivier 'reivilibre <[email protected]> Co-authored-by: Devon Hudson <[email protected]> Co-authored-by: Andrew Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed commit by commit.
It adds a few admin servlets that are used by MAS when in delegation mode to workers
This is lacking documentation, but we need this for the m.org migration