Skip to content

Bullet lists aren't formatted right #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bblacher opened this issue Apr 2, 2025 · 4 comments · Fixed by #4536
Closed

Bullet lists aren't formatted right #4525

bblacher opened this issue Apr 2, 2025 · 4 comments · Fixed by #4536
Labels
A-Event Rendering How events are shown in the timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bblacher
Copy link

bblacher commented Apr 2, 2025

Steps to reproduce

Send a multi depth bullet list from element web

Outcome

What did you expect?

Image

What happened instead?

Image

Your phone model

Pixel 8 Pro

Operating system version

Android 15

Application version and app store

Element X 2025.03.4 from GitHub releases (app-fdroid-arm64-v8a-release-signed.apk)

Homeserver

Synapse 1.127.1

Will you send logs?

No

Are you willing to provide a PR?

No

@bblacher bblacher added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 2, 2025
@jmartinesp
Copy link
Member

Can you share the event sources? It's probably because we're handling the HTML in a bad way, but we need to confirm it's not caused by some other markdown/plaintext -> HTML conversion issue.

@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Info This issue is blocked awaiting information from the reporter A-Event Rendering How events are shown in the timeline labels Apr 4, 2025
@bblacher
Copy link
Author

bblacher commented Apr 4, 2025

Sure, here you go:

{
  "content": {
    "body": "* aaa\n  * bbb\n  * ccc\n  * ddd\n    * eee\n    * fff\n    * ggg\n  * hhh\n* iii\n  * jjj\n  * kkk\n* lll",
    "format": "org.matrix.custom.html",
    "formatted_body": "<ul><li>aaa<ul><li>bbb<\/li><li>ccc<\/li><li>ddd<ul><li>eee<\/li><li>fff<\/li><li>ggg<\/li><\/ul><\/li><li>hhh<\/li><\/ul><\/li><li>iii<ul><li>jjj<\/li><li>kkk<\/li><\/ul><\/li><li>lll<\/li><\/ul>",
    "msgtype": "m.text"
  },
  "event_id": "$Z9ra_6F-VwRCI0weYsc6lnOa6etJNnsqfbY5SPzKzPg",
  "origin_server_ts": 1743615220499,
  "room_id": "!RKPUkCphPShscMQtzV:blacher.xyz",
  "sender": "@bblacher:blacher.xyz",
  "type": "m.room.message",
  "unsigned": {
    "age": 3079,
    "membership": "join"
  }
}

@jmartinesp
Copy link
Member

Interesting, the UI preview displays the nested list being rendered properly:

Image

However, in a real device it happens what you uploaded above: the leading margin is applied only to the text, not to the bullet item too.

Thanks for the report, we'll have to debug why this is happening, I think there might have been some regression either in one of our changes or an Android/Compose one.

@jmartinesp jmartinesp removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 4, 2025
@bblacher
Copy link
Author

bblacher commented Apr 7, 2025

Thanks for fixing this so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Event Rendering How events are shown in the timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants