Skip to content

Analytics | Add support for SuperProperties #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 31, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented May 30, 2024

Updated matrix-analytics-events to 0.23.0 and report SuperProperties for EXA, + test.

In order to set the SuperProperties I used a LaunchedEffect in LoggedInPresenter, let me know if fine (Note: this is not the case anymore now in RootPresenter following review)

Fixes https://github.com/element-hq/crypto-internal/issues/321

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link
Collaborator

ElementBot commented May 30, 2024

Warnings
⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.1

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

⚠️

gradle/libs.versions.toml#L24 - A newer version of androidx.camera:camera-view than 1.3.2 is available: 1.3.3

⚠️

gradle/libs.versions.toml#L213 - A newer version of androidx.appcompat:appcompat than 1.6.1 is available: 1.7.0

Generated by 🚫 dangerJS against 0d5bcd1

@bmarty
Copy link
Member

bmarty commented May 30, 2024

In order to set the SuperProperties I used a LaunchedEffect in LoggedInPresenter, let me know if fine

Since we do not need a Session to access this data, I think it's better to put this code in RootPresenter.

Copy link
Contributor

github-actions bot commented May 31, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tknRQw

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.58%. Comparing base (c8bd04c) to head (0d5bcd1).

Files Patch % Lines
...id/services/analytics/noop/NoopAnalyticsService.kt 0.00% 1 Missing ⚠️
...yticsproviders/posthog/PosthogAnalyticsProvider.kt 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2953      +/-   ##
===========================================
+ Coverage    75.56%   75.58%   +0.02%     
===========================================
  Files         1576     1576              
  Lines        37331    37345      +14     
  Branches      7253     7260       +7     
===========================================
+ Hits         28209    28228      +19     
+ Misses        5326     5321       -5     
  Partials      3796     3796              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr force-pushed the feature/valere/super_properties branch from bc7bbd2 to c3ba703 Compare May 31, 2024 10:54
@BillCarsonFr BillCarsonFr marked this pull request as ready for review May 31, 2024 11:01
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner May 31, 2024 11:01
@BillCarsonFr BillCarsonFr requested review from jmartinesp and removed request for a team May 31, 2024 11:01
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could also have added it as some kind of Initializer in ElementXApplication since it doesn't have much to do with navigation or UI, but it's not a big deal.

@BillCarsonFr BillCarsonFr enabled auto-merge May 31, 2024 11:56
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/super_properties branch from c3ba703 to 37d85c7 Compare May 31, 2024 12:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BillCarsonFr BillCarsonFr added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 31, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 31, 2024
@BillCarsonFr BillCarsonFr merged commit b4b07d8 into develop May 31, 2024
25 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/super_properties branch May 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants