Make logs less verbose, especially for sliding sync #2825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same config as iOS for most targets.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2825 +/- ##
===========================================
- Coverage 73.96% 73.96% -0.01%
===========================================
Files 1530 1530
Lines 36549 36555 +6
Branches 7075 7076 +1
===========================================
+ Hits 27034 27037 +3
- Misses 5810 5811 +1
- Partials 3705 3707 +2 ☔ View full report in Codecov by Sentry. |
…quest size of the bug reporter server.
…ng the log files (cherry picked from commit 056664077166fd8e32833a1a3d58deba2324d1ca)
|
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
bmarty
reviewed
May 13, 2024
| @@ -96,6 +96,7 @@ class BugReportPresenter @Inject constructor( | |||
| if (formState.value.description.length < 10) { | |||
| sendingAction.value = AsyncAction.Failure(BugReportFormError.DescriptionTooShort) | |||
| } else { | |||
| sendingAction.value = AsyncAction.Loading | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Make sliding sync and timeline logs from the Rust SDK less verbose.
Motivation and context
Some users (i.e. @frebib) were having issues uploading their logs with the new rotation config. It seems like our logs are way more verbose than the iOS ones.
Tested devices
Checklist