Permalink timeline #2759

bmarty · 2024-04-26T10:51:09Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Handle permalink navigation to Event.
Internal room and event navigation is fully supported with this changes. External link navigation will be handled separately.

Clicking on a replied Event preview navigate to the original Event.

Motivation and context

Permalink navigation

Screenshots / GIFs

See recorded ones

Tests

Send some Event permalink to a room and click on those links. The navigation should be properly handled.
Forward pagination is supported to, until the live is reached.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 23
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR

…ward insertion to "auto-scroll")

…ward pagination (and remove usage of PaginationStatus)

…ult on liveTimeline

…on (edit, reply, reaction)

github-actions · 2024-04-26T12:59:19Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e1zUUp

jmartinesp

LGTM in general, I have a few comments but nothing blocking. I'll wait until it's ready for the final review.

...t/android/features/messages/impl/timeline/components/virtual/TimelineLoadingMoreIndicator.kt

.../kotlin/io/element/android/features/messages/impl/timeline/factories/TimelineItemsFactory.kt

jmartinesp · 2024-04-29T10:03:12Z

...rc/test/kotlin/io/element/android/features/messages/impl/timeline/TimelineItemIndexerTest.kt

+    fun `test TimelineItemIndexer`() {
+        val eventIds = mutableListOf<EventId>()
+        val data = listOf(
+            aTimelineItemEvent().also { eventIds.add(it.eventId!!) },


Maybe make sure all ids used here don't match? They're random, so there's not much of a chance of it happening, so up to you.

Yes, I guess it's fine. I preferred to keep the randomness and store ids in eventIds, another solution would have been to create AN_EVENT_ID_3 and AN_EVENT_ID_4. Let's revisit later if it's worth it.

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/MatrixRoom.kt

...t/android/libraries/matrix/impl/timeline/postprocessor/LastForwardIndicatorsPostProcessor.kt

jmartinesp · 2024-04-29T10:14:30Z

...o/element/android/libraries/matrix/impl/timeline/postprocessor/RoomBeginningPostProcessor.kt


 /**
- * This timeline post-processor removes the room creation event and the self-join event from the timeline for DMs.
+ * This timeline post-processor removes the room creation event and the self-join event from the timeline for DMs
+ * or add the RoomBeginning item for non DM room.


I think I'd have split this in 2 processors, but it's no big deal.

… and `TimelineEvents.JumpToLive`

bmarty · 2024-04-29T12:40:18Z

I think there is an issue with enterSpecialMode, which is called on the current timeline here:

element-x-android/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerPresenter.kt

Line 270 in bf87b97

enterSpecialMode(relatedEventId)

But then message edition or reply is invoked on the live timeline, in RustMatrixRoom.

RustMatrixRoom.enterSpecialMode is not used anymore, which is part of the problem.

I think special modes, and so reply and edition have to occurs on the current timeline, because the Event have to be known. But we will not have local echo, which are only handled by the live timeline.

…d on the current timeline.

sonarqubecloud · 2024-04-29T22:06:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ganfra and others added 28 commits April 16, 2024 21:18

Timeline : expose new pagination status api

2ae6931

Timeline : start reworking timeline apis

83e7c13

Merge develop into feature/fga/permalink_timeline

ff92551

Timeline permalink : continue to iterate (try a strategy to avoid for…

0d7cffe

…ward insertion to "auto-scroll")

Timeline permalink : automatic focus on live when reaching end of for…

b1dd225

…ward pagination (and remove usage of PaginationStatus)

Timeline : add box around TimelineItemVirtualRow

fbfcc36

Timeline : remove highlightedEventId to only use focusedEventId

3c961a2

Timeline permalink : add focused event modifier

20e172c

Timeline permalink : branch permalink on event of other room

b764933

Timeline : use latest api

7094955

Timeline : exposes same methods as the rust type and use them by defa…

a6d8209

…ult on liveTimeline

Timeline : makes sure to use the right timeline when making some acti…

fed1733

…on (edit, reply, reaction)

Timeline permalink : start updating tests

bf87b97

Timeline : continue to fix more tests...

bffa2d7

Timeline : makes sure all tests are passing

97b9d75

Timeline : do not cancel pagination to avoid stuck timeline.

0e98659

Timeline : rename isTimelineEmpty to hasAnyEvent

6632b2a

Timeline permalink : scroll to fetched event when known

7ac6e41

Timeline : try to get better forward pagination.

7b4fa14

Merge branch 'develop' into feature/fga/permalink_timeline

2c8abbe

Fix compilation issue (develop has been merged here)

94df730

Format and cleanup files

300d3e3

Add preview for focusedEvent.

076d224

Improve focusedEvent rendering when sender information are displayed.

2dd122e

Add missing color preview.

b8cb2d9

Fix issue with Gradient rendering.

83d9e77

Move LiveTimelineProvider to the test module.

f4f5888

Improve preview of TimelineLoadingMoreIndicator

cf06aca

Fix detekt issues

636c024

jmartinesp requested a review from a team as a code owner April 29, 2024 10:15

jmartinesp requested review from jmartinesp and removed request for a team April 29, 2024 10:15

jmartinesp reviewed Apr 29, 2024

View reviewed changes

bmarty added 6 commits April 29, 2024 12:31

Add test on focusRequestState for event TimelineEvents.FocusOnEvent…

4704b12

… and `TimelineEvents.JumpToLive`

Remove unused newTimelineById

1be2e18

Add documentation on new API.

a8d66ec

Code optimization.

8eccd1b

No need to keep innerTimeline as a class member.

37d0b9c

Remove unnecessary default value.

0190d5d

bmarty added 3 commits April 29, 2024 15:48

Add log in case of error.

ddb00a2

Ensure editMessage, enterSpecialMode and replyMessage are calle…

49dd4ad

…d on the current timeline.

Map all replyTo data and add preview for loading and erorr case.

b7970b2

bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 29, 2024

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 29, 2024

ElementBot and others added 4 commits April 29, 2024 15:50

Update screenshots

e49d098

Fix issue when retrieving Event detail. The wrong method was used.

a60779a

Handle click on reply navigation.

200b432

changelog

4de8713

bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 29, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 29, 2024

Fix tests after change on InReplyTo classes

906650b

jmartinesp approved these changes Apr 30, 2024

View reviewed changes

bmarty merged commit ae8ee87 into develop Apr 30, 2024
14 of 16 checks passed

bmarty deleted the feature/fga/permalink_timeline branch April 30, 2024 08:58

This was referenced Apr 30, 2024

[Task] Click on message permalink #2645

Closed

[Task] Permalink: navigate to replied Event #2646

Closed

[Task] Forward pagination #2649

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Permalink timeline #2759

Permalink timeline #2759

Uh oh!

bmarty commented Apr 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 26, 2024 •

edited

Loading

Uh oh!

jmartinesp left a comment

Uh oh!

Uh oh!

Uh oh!

jmartinesp Apr 29, 2024

Uh oh!

bmarty Apr 29, 2024

Uh oh!

Uh oh!

Uh oh!

jmartinesp Apr 29, 2024

Uh oh!

bmarty commented Apr 29, 2024

Uh oh!

sonarqubecloud bot commented Apr 29, 2024

Uh oh!

Uh oh!

Uh oh!

Permalink timeline #2759

Permalink timeline #2759

Uh oh!

Conversation

bmarty commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions bot commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmartinesp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmartinesp Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

bmarty Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmartinesp Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

bmarty commented Apr 29, 2024

Uh oh!

sonarqubecloud bot commented Apr 29, 2024

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

bmarty commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024 •

edited

Loading