Skip to content

Fix compile with noop analytics provider #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

SpiritCroc
Copy link
Contributor

@SpiritCroc SpiritCroc commented Apr 12, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add ScreenTracker impl for noop analytics

Motivation and context

noop analytics didn't build since v0.4.8. Setting io.element.android-compose-library in build.gradle.kts is furthermore required to not make it crash after adding the NoopScreenTracker.

Screenshots / GIFs

Tests

In DependencyHandleScope.kt, switch to

    implementation(project(":services:analytics:noop"))
    //implementation(project(":services:analytics:impl"))
    //implementation(project(":services:analyticsproviders:posthog"))
    //implementation(project(":services:analyticsproviders:sentry"))

and try to compile.
Also make sure to test the "Troubleshoot notifications" screen once it compiles, if it crashes or not.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Sign-off

Signed-off-by: Tobias Büttner [email protected]

@SpiritCroc SpiritCroc requested a review from a team as a code owner April 12, 2024 19:05
@SpiritCroc SpiritCroc requested review from bmarty and removed request for a team April 12, 2024 19:05
Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@SpiritCroc SpiritCroc force-pushed the noop-analytics-screen-tracker branch from 2fc9a60 to 6e2d163 Compare April 12, 2024 19:12
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.57%. Comparing base (a8db707) to head (6e2d163).

Files Patch % Lines
...droid/services/analytics/noop/NoopScreenTracker.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2698      +/-   ##
===========================================
- Coverage    73.58%   73.57%   -0.01%     
===========================================
  Files         1460     1461       +1     
  Lines        35335    35337       +2     
  Branches      6792     6793       +1     
===========================================
  Hits         26000    26000              
- Misses        5796     5798       +2     
  Partials      3539     3539              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Apr 15, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and sorry I missed to update the noop module.

@bmarty bmarty merged commit 80eb785 into element-hq:develop Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants