Room navigation

[ganfra]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

This PR introduces a JoinedRoomFlowNode which is the previous RoomFlowNode. RoomFlowNode is now responsible to listen on room membership to decide which node to render, either JoinedRoomFlowNode or the new JoinRoomNode.

The JoinRoomNode is not completed yet, but this is a first draft.

Motivation and context

Closes #2654
Closes #2658
Handles some part of element-hq/element-meta#2341

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ssnFDA

[codecov]

Codecov Report

Attention: Patch coverage is 51.30597% with 261 lines in your changes are missing coverage. Please review.

Project coverage is 73.12%. Comparing base (8cfa45e) to head (a5240e3).
Report is 39 commits behind head on develop.

Files	Patch %	Lines
...ent/android/features/joinroom/impl/JoinRoomView.kt	0.00%	138 Missing ⚠️
...id/features/joinroom/impl/JoinRoomStateProvider.kt	0.00%	39 Missing ⚠️
...es/invite/impl/response/AcceptDeclineInviteView.kt	55.00%	10 Missing and 8 partials ⚠️
...nt/android/features/joinroom/impl/JoinRoomState.kt	72.72%	6 Missing and 3 partials ⚠️
...ures/invite/impl/invitelist/InviteListPresenter.kt	27.27%	8 Missing ⚠️
...vite/impl/response/AcceptDeclineInvitePresenter.kt	85.41%	2 Missing and 5 partials ⚠️
...te/impl/response/AcceptDeclineInviteViewWrapper.kt	0.00%	7 Missing ⚠️
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt	86.53%	2 Missing and 5 partials ⚠️
...ndroid/features/joinroom/impl/di/JoinRoomModule.kt	0.00%	6 Missing ⚠️
...roid/features/roomdirectory/api/RoomDescription.kt	77.27%	3 Missing and 2 partials ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2695      +/-   ##
===========================================
- Coverage    73.57%   73.12%   -0.45%     
===========================================
  Files         1460     1477      +17     
  Lines        35317    35689     +372     
  Branches      6790     6859      +69     
===========================================
+ Hits         25984    26098     +114     
- Misses        5795     6040     +245     
- Partials      3538     3551      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

LGTM, something strange though:
When clicking on an invite, user has the time to see the wording "Preview not available".
But when it's done in airplane mode, it's not the case.
There is maybe some possible improvement on this?

Also, showing the roomId is a bit strange:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[bmarty]

I am trying to figure out why the JoinRoomView is not covered by Test. There are some Preview, but Showkase does not seem to detect them. Still investigating.

Also, the code coverage is not good (-0.45%), this is related to the issue above, but not only.

Regarding the timing, we need to merge the PR. We will investigate the coverage issue later.