Fix getOidcCallbackUrl for Element Desktop (#29711)

t3chguy · web-flow · commit c929eedd817d · 2025-04-11T14:44:22.000Z
Signed-off-by: Michael Telatynski &lt;7t3chguy@gmail.com&gt;
diff --git a/src/vector/platform/ElectronPlatform.tsx b/src/vector/platform/ElectronPlatform.tsx
@@ -479,7 +479,7 @@ export default class ElectronPlatform extends BasePlatform {
         const url = super.getOidcCallbackUrl();
         url.protocol = "io.element.desktop";
         // Trim the double slash into a single slash to comply with https://datatracker.ietf.org/doc/html/rfc8252#section-7.1
-        if (url.href.startsWith(`${url.protocol}://`)) {
+        if (url.href.startsWith(`${url.protocol}//`)) {
             url.href = url.href.replace("://", ":/");
         }
         return url;

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ export default class ElectronPlatform extends BasePlatform {`
`479`	`479`	`const url = super.getOidcCallbackUrl();`
`480`	`480`	`url.protocol = "io.element.desktop";`
`481`	`481`	`// Trim the double slash into a single slash to comply with https://datatracker.ietf.org/doc/html/rfc8252#section-7.1`
`482`		- if (url.href.startsWith(`${url.protocol}://`)) {
	`482`	+ if (url.href.startsWith(`${url.protocol}//`)) {
`483`	`483`	`url.href = url.href.replace("://", ":/");`
`484`	`484`	`}`
`485`	`485`	`return url;`