Skip to content

Commit bd14241

Browse files
authored
Downstream test element-modules in merge queue (#29899)
* Downstream test element-modules in merge queue Signed-off-by: Michael Telatynski <[email protected]> * Typo Signed-off-by: Michael Telatynski <[email protected]> * Update cache key to be arch-aware Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
1 parent 581920e commit bd14241

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

.github/workflows/end-to-end-tests.yaml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,8 @@ jobs:
157157
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4
158158
id: playwright-cache
159159
with:
160-
path: |
161-
~/.cache/ms-playwright
162-
key: ${{ runner.os }}-playwright-${{ steps.playwright.outputs.version }}
160+
path: ~/.cache/ms-playwright
161+
key: ${{ runner.os }}-${{ runner.arch }}-playwright-${{ steps.playwright.outputs.version }}
163162

164163
- name: Install Playwright browsers
165164
if: steps.playwright-cache.outputs.cache-hit != 'true'
@@ -186,9 +185,19 @@ jobs:
186185
path: blob-report
187186
retention-days: 1
188187

188+
downstream-modules:
189+
name: Downstream Playwright tests [element-modules]
190+
needs: build
191+
if: inputs.skip != true && github.event_name == 'merge_group'
192+
uses: element-hq/element-modules/.github/workflows/reusable-playwright-tests.yml@main
193+
with:
194+
webapp-artifact: webapp
195+
189196
complete:
190197
name: end-to-end-tests
191-
needs: playwright
198+
needs:
199+
- playwright
200+
- downstream-modules
192201
if: always()
193202
runs-on: ubuntu-24.04
194203
steps:
@@ -232,5 +241,5 @@ jobs:
232241
path: playwright-report
233242
retention-days: 14
234243

235-
- if: needs.playwright.result != 'skipped' && needs.playwright.result != 'success'
244+
- if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
236245
run: exit 1

0 commit comments

Comments
 (0)