feat: rework spacing of room list item

Author: florianduros

res/css/views/rooms/RoomListPanel/_RoomListItemView.pcss

@@ -19,7 +19,7 @@
     cursor: pointer;
 
     .mx_RoomListItemView_container {
-        padding-left: var(--cpd-space-2x);
+        padding-left: var(--cpd-space-3x);
         font: var(--cpd-font-body-md-regular);
         height: 100%;
 
@@ -30,6 +30,7 @@
             border-bottom: var(--cpd-border-width-0-5) solid var(--cpd-color-bg-subtle-secondary);
             box-sizing: border-box;
             min-width: 0;
+            padding-right: var(--cpd-space-5x);
 
             .mx_RoomListItemView_text {
                 min-width: 0;
@@ -56,26 +57,18 @@
     background-color: var(--cpd-color-bg-action-secondary-hovered);
 }
 
-.mx_RoomListItemView_menu_open .mx_RoomListItemView_content {
-    padding-right: var(--cpd-space-1-5x);
+.mx_RoomListItemView_menu_open .mx_RoomListItemView_container .mx_RoomListItemView_content {
+    // The figma uses 16px padding (--cpd-space-4x) but due to https://github.com/element-hq/compound-web/issues/331
+    // the icon size of the menu is 18px instead of 20px with a different internal padding
+    // We need to use 18px to align the icon with the others icons
+    // 18px is not available in compound spacing
+    padding-right: 18px;
 }
 
 .mx_RoomListItemView_selected {
     background-color: var(--cpd-color-bg-action-secondary-pressed);
 }
 
-.mx_RoomListItemView_notification_decoration {
-    .mx_RoomListItemView_content {
-        padding-right: var(--cpd-space-2x);
-    }
-}
-
-.mx_RoomListItemView_empty {
-    .mx_RoomListItemView_content {
-        padding-right: var(--cpd-space-3x);
-    }
-}
-
 .mx_RoomListItemView_bold .mx_RoomListItemView_roomName {
     font: var(--cpd-font-body-md-semibold);
 }

src/components/views/rooms/NotificationDecoration.tsx

@@ -64,7 +64,7 @@ export function NotificationDecoration({
         <Flex
             align="center"
             justify="center"
-            gap="var(--cpd-space-1-5x)"
+            gap="var(--cpd-space-1x)"
             {...props}
             data-testid="notification-decoration"
         >

src/components/views/rooms/RoomListPanel/RoomListItemMenuView.tsx

@@ -47,7 +47,7 @@ export function RoomListItemMenuView({ room, setMenuOpen }: RoomListItemMenuView
     const vm = useRoomListItemMenuViewModel(room);
 
     return (
-        <Flex className="mx_RoomListItemMenuView" align="center" gap="var(--cpd-space-0-5x)">
+        <Flex className="mx_RoomListItemMenuView" align="center" gap="var(--cpd-space-1x)">
             {vm.showMoreOptionsMenu && <MoreOptionsMenu setMenuOpen={setMenuOpen} vm={vm} />}
             {vm.showNotificationMenu && <NotificationMenu setMenuOpen={setMenuOpen} vm={vm} />}
         </Flex>

src/components/views/rooms/RoomListPanel/RoomListItemView.tsx

@@ -47,15 +47,10 @@ export const RoomListItemView = memo(function RoomListItemView({
     const showHoverDecoration = isMenuOpen || isHover;
     const showHoverMenu = showHoverDecoration && vm.showHoverMenu;
 
-    const isInvitation = vm.notificationState.invited;
-    const isNotificationDecorationVisible = isInvitation || (!showHoverDecoration && vm.showNotificationDecoration);
-
     return (
         <button
             ref={ref}
             className={classNames("mx_RoomListItemView", {
-                mx_RoomListItemView_empty: !isNotificationDecorationVisible && !showHoverDecoration,
-                mx_RoomListItemView_notification_decoration: isNotificationDecorationVisible,
                 mx_RoomListItemView_hover: showHoverDecoration,
                 mx_RoomListItemView_menu_open: showHoverMenu,
                 mx_RoomListItemView_selected: isSelected,
@@ -83,7 +78,7 @@ export const RoomListItemView = memo(function RoomListItemView({
                 <RoomAvatarView room={room} />
                 <Flex
                     className="mx_RoomListItemView_content"
-                    gap="var(--cpd-space-3x)"
+                    gap="var(--cpd-space-2x)"
                     align="center"
                     justify="space-between"
                 >