Feature/bca/migrate rust in db #8405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bma/crypto_rust_default
branch
from
bb31a2d to
f1036d4
Compare
BillCarsonFr
force-pushed
the
feature/bca/migrate_rust_in_db
branch
from
d13521f to
5e28631
Compare
bmarty
reviewed
May 9, 2023
| migrateOperation.dynamicExecute(realm, rustDirectory, rustEncryptionConfiguration.getDatabasePassphrase()) | ||
|
|
||
| // wa can't delete all for now, but we can do some cleaning | ||
| realm.schema.get("OlmSessionEntity")?.transform { |
There was a problem hiding this comment.
I think you must also delete the file OlmSessionEntity to be able to do that, because else it will be added again to the schema.
There was a problem hiding this comment.
Added an assertion to the test to ensure that entities are removed. But yeah we keep the table for now (albeit empty)
bmarty
approved these changes
May 9, 2023
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
`Perform the legcay to rust migration by using a new CryptoDB migeration (
MigrateCryptoTo022), instead of in the DI layer.Main change is that the former code was migrating a
Realminstance, but now as it's in a migration it has to do it with aDynamicRealm. I kept the former code as a utility (could be deleted?), but only the dynamic migration is used now.Some of the database migration test have been updated as the rust migration is now down seamlessly.
Notice that now, reverting from rust to kotlin crypto will fail due to incompatible db. Anyhow such back migration is not technically possible atm due to lack of support in vodozemac. (will fail with
Illegal Argument: Provided schema version 21 is less than last set version 22.)Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist