-
Notifications
You must be signed in to change notification settings - Fork 782
Increase session manager test coverage #7836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
@Test | ||
fun `given ip addresses are currently not visible then then visibility is set as true`() { | ||
// Given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is missing tabs on this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding unit tests! I have just added a minor comment about code alignement style.
LogError: Error: Could not find the Dangerfile at ./tools/danger/dangerfile-lint.js - does a file exist at danger/dangerfile-lint.js in ./tools?.
at /usr/src/danger/distribution/platforms/GitHub.js:166:27
at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-0b1daa64.json |
Kudos, SonarCloud Quality Gate passed!
|
Type of change
Content
This PR aims to increase unit test coverage of the new session manager feature by including missing unit tests for business classes.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist