Skip to content

[Rich text editor] Add plain text mode #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[Rich text editor] Add plain text mode #7452

wants to merge 5 commits into from

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 26, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add a toggle to disable rich text editing and enter plain text mode.

Motivation and context

The plain text mode is a fallback for the rich text editor bypassing it completely.

Note that the plain text mode does not yet support markdown.

PSU-780

Screenshots / GIFs

Before After
Toggle before-light after-light-on
Toggle before-dark after-dark
Toggle off after-light-off
Plain text mode image

Tests

UI

  • Change the text formatting setting
  • Note the new setting is reflected in the UI

Message format

  • Switch the text formatting setting on
  • Note that messages are sent in HTML
  • Switch the text formatting setting off
  • Note that messages are sent as plain text

Editor

  • Type a message
  • Toggle the setting
  • Note that the message is not cleared from the editor

Persistence

  • Change the text formatting setting
  • Restart the app
  • View the text formatting setting
  • Note the new setting is persisted

Tested devices

  • Physical
  • Emulator
  • OS version(s): 33, 21

Checklist

@jonnyandrew jonnyandrew changed the title # [Rich text editor] Add plain text mode to rich text editor [Rich text editor] Add plain text mode Oct 26, 2022
@jonnyandrew jonnyandrew marked this pull request as ready for review October 26, 2022 12:55
@jonnyandrew jonnyandrew requested review from a team and jmartinesp and removed request for a team October 26, 2022 12:55
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't like the idea of duplicating even more components, but the solution seems solid.

@jmartinesp
Copy link
Member

This was already merged to the resilience-rc branch and that branch to develop, so we can close this PR.

@jmartinesp jmartinesp closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants