-
Notifications
You must be signed in to change notification settings - Fork 784
Voice Broadcast - Listening #7387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Broadcast - Listening #7387
Conversation
49f6427
to
441001b
Compare
I still haven't looked at the code, but one thing I've noticed is that the broadcast pauses as soon as the device gets locked, so maybe it would be nice to keep the screen on while you're recording? Also, a question: how long does it take the voice broadcast to start playing? I tried listening to it ~5s after it had started and nothing came out of the speakers, I thought it was broken. Then I tried again like 20s later and it was working. Besides that it seems to be working fine 👍 . I'll take a look at the code and approve if I don't find any major issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just the couple of questions/points mentioned above, but they're not blockers.
Keeping the screen on while recording or listening would be nice for UX if it can be implemented quickly.
@jmartinesp Thanks for your quick review! In this PR, the duration of the voice messages is 30 sec. There is no indicator in the UI about the availability of the messages, I agree it is not nice from a UX point of view. |
441001b
to
d53ad43
Compare
SonarCloud Quality Gate failed. |
Type of change
Content
Add the ability to listen to a voice broadcast.
For the moment, the incoming voice messages are not added to the queue when the listening is ongoing.
Motivation and context
Continue #7127
Screenshots / GIFs
Tests
Tested devices
Checklist