Nightly build published on Firebase #6478

bmarty · 2022-07-05T22:20:03Z

See details in #5803

See the file nightly.md from this PR to get more details.

The only not tested thing is the GitHub workflow. Can be tested only once merged ://

Closes #5803

…kt and shortcuts.xml.

… if it's a nightly build.

…ather do some copy paste, to avoid a warning about values being replaced

…release` to avoid too many copy paste.

bmarty · 2022-07-12T10:15:38Z

vector/build.gradle

@@ -1,6 +1,7 @@
 import com.android.build.OutputFile

 apply plugin: 'com.android.application'
+apply plugin: 'com.google.firebase.appdistribution'


I hope this will not be a problem for F-Droid build, but since we already have non free com.google.android.gms.oss-licenses-plugin just below, I think this will be OK.

if we find out it is a problem we can use a similar mechanism to the coverage task and conditionally apply the plugin

ouchadam · 2022-07-12T11:26:41Z

.github/workflows/nightly.yml

+      - name: Prepare changelog file
+        run: |
+          mv towncrier.toml towncrier.toml.bak
+          sed 's/CHANGES\.md/CHANGES_NIGHTLY\.md/' towncrier.toml.bak > towncrier.toml


should we commit the changes file after successfully deploying the nightly?

I do not think this is necessary, this is just a temporary file which will contain the changelog sent to firebase.

ouchadam · 2022-07-12T11:27:08Z

vector/src/main/res/drawable/ic_launcher_background.xml

@@ -5,6 +5,6 @@
    android:viewportHeight="108">
  <path
      android:pathData="m0,0h108v108h-108z"
-      android:fillColor="#0DBD8B"
+      android:fillColor="@color/launcher_background"


ouchadam · 2022-07-12T11:27:55Z

vector/build.gradle

@@ -268,6 +278,40 @@ android {
            }
            // signingConfig signingConfigs.release
        }
+
+        nightly {
+            applicationIdSuffix ".nightly"


we'll also need to update the sygnal config to include the new package/sha

Are you sure about that? (I will double check that I can receive Push with the nightly)

For me it should be working as it's a suffix

ah you're right! it's working locally for me, I thought we'd need to introduce the package into https://github.com/matrix-org/sygnal/blob/main/sygnal.yaml.sample#L203

I guess we're okay because the GCM api key is the same for nightly and debug (I thought firebase would validate package names, shas and api keys 🤔 )

ouchadam · 2022-07-12T11:29:29Z

.github/workflows/nightly.yml

+          yes n | towncrier --version nightly
+      - name: Build and upload Gplay Nightly APK
+        run: |
+          ./gradlew assembleGplayNightly appDistributionUploadGplayNightly $CI_GRADLE_ARG_PROPERTIES --stacktrace


in the future we may want to also run the tests beforehand to ensure we don't release a potentially broken build~

sonarqubecloud · 2022-07-12T12:46:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

ouchadam · 2022-07-12T12:59:22Z

docs/nightly_build.md

+
+*Note:* Due to a limitation of Firebase, the nightly build is the universal build, which means that the size of the APK is a bit bigger, but this should not have any other side effect.
+
+## How to register to get nightly build


as an FYI, it looks like the default tester limit is 500 https://firebase.google.com/docs/app-distribution/add-remove-testers?platform=android#add-remove-testers-group , we'll need to request more slots (if needed) https://console.firebase.google.com/project/_/appdistribution/limits

ouchadam · 2022-07-12T13:00:04Z

docs/nightly_build.md

+
+## How to register to get nightly build
+
+Provide your email to the Android team, who will add it to the list "External testers" on Firebase. You will then receive an invite on the provided email.


should we mention the user will need to have a google account to access the nightly build via firebase?

Are you sure about that? There are other email type in the group external-testers

that's my understanding, it sounds like you're meant to associate external emails to a google account

Step 1: Sign in with Google to accept the invitation

After opening an invitation to test an app, you can sign in with any Google account to accept the invitation, not just the account to which the invitation was originally sent.

A Google account can be associated with any email address, not only addresses with Gmail or G Suite domains. Find out how to sign in with another email address.

https://firebase.google.com/docs/app-distribution/get-set-up-as-a-tester?platform=android

ganfra

Ok for me if pushs are working

bmarty added 3 commits July 5, 2022 16:07

Setup nightly buildType

f469450

Add google-services.json for nightly builds

586c227

Add fallback for submodules

8434fb9

bmarty force-pushed the feature/bma/nightly branch from 6595bd5 to 3ae695a Compare July 6, 2022 08:09

bmarty changed the title ~~Nightly build publish on Firebase~~ Nightly build published on Firebase Jul 6, 2022

bmarty and others added 7 commits July 6, 2022 15:37

Add sources for nightly. Use release version, change AnalyticsConfig.…

ea5b2b3

…kt and shortcuts.xml.

Change icon background color for nightly build

a030769

Add label for rageshake to know the build type, in particular to know…

5793a38

… if it's a nightly build.

Add "-nightly" suffix to version name

388a380

Configure Firebase appdistribution plugin

11b2cd3

Add GitHub action to build and publish the nightly build.

cdaec0e

Changelog

253480f

bmarty force-pushed the feature/bma/nightly branch from 3ae695a to 253480f Compare July 6, 2022 13:39

initWith release does not take care of postprocessing block, so r…

b3e8612

…ather do some copy paste, to avoid a warning about values being replaced

bmarty mentioned this pull request Jul 7, 2022

Add GitHub action to check for a towncrier file #6482

Merged

bmarty added 2 commits July 7, 2022 17:40

Add documentation about nightly build.

64871e3

Do not alter the app name for the nightly, and finally use `initWith …

95f4d88

…release` to avoid too many copy paste.

bmarty force-pushed the feature/bma/nightly branch from 35b03ec to 95f4d88 Compare July 12, 2022 10:09

bmarty requested review from ouchadam and ganfra July 12, 2022 10:13

bmarty marked this pull request as ready for review July 12, 2022 10:13

bmarty commented Jul 12, 2022

View reviewed changes

ouchadam reviewed Jul 12, 2022

View reviewed changes

ganfra approved these changes Jul 13, 2022

View reviewed changes

ouchadam approved these changes Jul 14, 2022

View reviewed changes

bmarty merged commit 4ed24b5 into develop Jul 18, 2022

bmarty deleted the feature/bma/nightly branch July 18, 2022 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nightly build published on Firebase #6478

Nightly build published on Firebase #6478

bmarty commented Jul 5, 2022 •

edited

Loading

bmarty Jul 12, 2022

ouchadam Jul 12, 2022

ouchadam Jul 12, 2022

bmarty Jul 13, 2022

ouchadam Jul 12, 2022

ouchadam Jul 12, 2022

bmarty Jul 12, 2022

ganfra Jul 13, 2022

ouchadam Jul 14, 2022

ouchadam Jul 12, 2022

sonarqubecloud bot commented Jul 12, 2022

ouchadam Jul 12, 2022 •

edited

Loading

ouchadam Jul 12, 2022

bmarty Jul 12, 2022

ouchadam Jul 13, 2022

ganfra left a comment •

edited

Loading


		Note: Due to a limitation of Firebase, the nightly build is the universal build, which means that the size of the APK is a bit bigger, but this should not have any other side effect.

		## How to register to get nightly build


		## How to register to get nightly build

		Provide your email to the Android team, who will add it to the list "External testers" on Firebase. You will then receive an invite on the provided email.

Nightly build published on Firebase #6478

Nightly build published on Firebase #6478

Conversation

bmarty commented Jul 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 12, 2022

ouchadam Jul 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ganfra left a comment • edited Loading

Choose a reason for hiding this comment

bmarty commented Jul 5, 2022 •

edited

Loading

ouchadam Jul 12, 2022 •

edited

Loading

ganfra left a comment •

edited

Loading