-
Notifications
You must be signed in to change notification settings - Fork 784
Prevent widget web view from reloading on screen / orientation change (PSF-1034) #6140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… (PSF-1034) Signed-off-by: Johannes Marbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
@ouchadam I heard you're short on reviews so maybe you could give the second review here in case Francois doesn't have time to get to it? 😇 |
@@ -306,7 +306,9 @@ | |||
android:supportsPictureInPicture="true" /> | |||
|
|||
<activity android:name=".features.terms.ReviewTermsActivity" /> | |||
<activity android:name=".features.widgets.WidgetActivity" /> | |||
<activity android:name=".features.widgets.WidgetActivity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we'd let the system reconfigure but avoid calling loadUrl
on the webview on each creation buttt as we're already using this pattern in other screens 👍
Matrix SDKIntegration Tests Results:
|
Type of change
Content
This applies the same
configChange
settings we use onVectorCallActivity
andVectorJitsiActivity
toWidgetActivity
to prevent the widget web view from reloading on device screen or orientation changes.Motivation and context
We'll be using the widget system to integrate Element Call into the app. Currently rotating the device causes the widget web view to reload which disconnects the call.
Tests
Tested devices
Checklist