Poll refactoring with unit tests (PSF-1020) #6074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team,
Claire1817 and
ericdecanini
and removed request for
a team
ericdecanini
suggested changes
May 17, 2022
...matrix/android/sdk/internal/session/room/aggregation/poll/DefaultPollAggregationProcessor.kt
Outdated
Show resolved
Hide resolved
...rg/matrix/android/sdk/internal/session/room/aggregation/poll/PollAggregationProcessorTest.kt
Outdated
Show resolved
Hide resolved
...rg/matrix/android/sdk/internal/session/room/aggregation/poll/PollAggregationProcessorTest.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/test/java/org/matrix/android/sdk/test/fakes/FakeRealm.kt
Outdated
Show resolved
Hide resolved
onurays
changed the title
ericdecanini
approved these changes
May 19, 2022
* develop: (251 commits) Space explore rooms screen alignment with design in figma (#5834) leaving space aligned with ios (#5942) Fix usage of System.currentTimeMillis(). This a bit mocky but anyway it's better to use SystemClock.elapsedRealtime() for this case. Update TimelinePreviousLastForwardTest.kt Changelog.d Rename 'getDomain' to 'getServerName'. Well-known lookups should not include the port of a server. Ah it was used in Gplay variant. Anyway I think we can still remove this now. Fix parsing of location data in non encrypted room Additionally increment for TimelinePreviousLastForwardTest Notify other devices of acceptance of verification request Instead of using a magic number, explicitly test for the events we expect. Adding comments on some strings and removing non necessary plural Remove ShortcutBadger lib and usage (it was dead code) Version++ Fastlane file Towncrier Add `.login` to get the username of the PR merger. Rename folder for the PlayStore Remove empty translations ... # Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/SessionModule.kt
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregating poll editing, poll response and poll end events were handled in
EventRelationsAggregationProcessorclass which was over crowded. Furthermore it wasn't easy to write unit test for this class.Within this PR, poll implementation moved to a separate class and unit tests are written.
Test coverage: