Merge pull request #5091 from vector-im/feature/adm/timeline-item-crash

bmarty · web-flow · commit c487add2cdda · 2022-01-28T13:40:16.000+01:00
Timeline recycling crash
diff --git a/changelog.d/5091.bugfix b/changelog.d/5091.bugfix
@@ -0,0 +1 @@
+Fixing crashes when quickly scrolling or restoring the room timeline  
diff --git a/vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageTextItem.kt b/vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageTextItem.kt
@@ -109,6 +109,7 @@ abstract class MessageTextItem : AbsMessageItem<MessageTextItem.Holder>() {
             val textFuture = PrecomputedTextCompat.getTextFuture(message, TextViewCompat.getTextMetricsParams(this), null)
             setTextFuture(textFuture)
         } else {
+            setTextFuture(null)
             text = message
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fixing crashes when quickly scrolling or restoring the room timeline`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ abstract class MessageTextItem : AbsMessageItem<MessageTextItem.Holder>() {`
`109`	`109`	`val textFuture = PrecomputedTextCompat.getTextFuture(message, TextViewCompat.getTextMetricsParams(this), null)`
`110`	`110`	`setTextFuture(textFuture)`
`111`	`111`	`} else {`
	`112`	`+ setTextFuture(null)`
`112`	`113`	`text = message`
`113`	`114`	`}`
`114`	`115`	`}`