Skip to content

Commit 8dbfafb

Browse files
authored
Merge pull request #7102 from vector-im/feature/eric/double-space-click-fix
Fixes Crash On Double Click Of Space FABs
2 parents 147dac8 + 34303c4 commit 8dbfafb

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

changelog.d/7102.bugfix

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes crash when quickly double clicking FABs in the new app layout

vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt

+4-5
Original file line numberDiff line numberDiff line change
@@ -201,13 +201,12 @@ class NewHomeDetailFragment :
201201
private fun setupFabs() {
202202
showFABs()
203203

204-
views.newLayoutCreateChatButton.setOnClickListener {
205-
newChatBottomSheet.show(requireActivity().supportFragmentManager, NewChatBottomSheet.TAG)
204+
views.newLayoutCreateChatButton.debouncedClicks {
205+
newChatBottomSheet.takeIf { !it.isAdded }?.show(requireActivity().supportFragmentManager, NewChatBottomSheet.TAG)
206206
}
207207

208-
views.newLayoutOpenSpacesButton.setOnClickListener {
209-
// Click action for open spaces modal goes here
210-
spaceListBottomSheet.show(requireActivity().supportFragmentManager, SpaceListBottomSheet.TAG)
208+
views.newLayoutOpenSpacesButton.debouncedClicks {
209+
spaceListBottomSheet.takeIf { !it.isAdded }?.show(requireActivity().supportFragmentManager, SpaceListBottomSheet.TAG)
211210
}
212211
}
213212

vector/src/main/java/im/vector/app/features/home/room/list/home/NewChatBottomSheet.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import im.vector.app.features.navigation.Navigator
2727
import javax.inject.Inject
2828

2929
@AndroidEntryPoint
30-
class NewChatBottomSheet @Inject constructor() : BottomSheetDialogFragment() {
30+
class NewChatBottomSheet : BottomSheetDialogFragment() {
3131

3232
@Inject lateinit var navigator: Navigator
3333

0 commit comments

Comments
 (0)