making comparator override non null as kotlin guards against this

ouchadam · ouchadam · commit 5f2cb671e2d2 · 2022-05-17T10:35:14.000+01:00
diff --git a/vector/src/main/java/im/vector/app/features/onboarding/ftueauth/MatrixOrgRegistrationStagesComparator.kt b/vector/src/main/java/im/vector/app/features/onboarding/ftueauth/MatrixOrgRegistrationStagesComparator.kt
@@ -20,8 +20,8 @@ import org.matrix.android.sdk.api.auth.registration.Stage
 
 class MatrixOrgRegistrationStagesComparator : Comparator<Stage> {
 
-    override fun compare(a: Stage?, b: Stage?): Int {
-        return (a?.toPriority() ?: 0).compareTo(b?.toPriority() ?: 0)
+    override fun compare(a: Stage, b: Stage): Int {
+        return a.toPriority().compareTo(b.toPriority())
     }
 
     private fun Stage.toPriority() = when (this) {

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ import org.matrix.android.sdk.api.auth.registration.Stage`
`20`	`20`
`21`	`21`	`class MatrixOrgRegistrationStagesComparator : Comparator<Stage> {`
`22`	`22`
`23`		`- override fun compare(a: Stage?, b: Stage?): Int {`
`24`		`- return (a?.toPriority() ?: 0).compareTo(b?.toPriority() ?: 0)`
	`23`	`+ override fun compare(a: Stage, b: Stage): Int {`
	`24`	`+ return a.toPriority().compareTo(b.toPriority())`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`private fun Stage.toPriority() = when (this) {`