Skip to content

Commit 113a1d2

Browse files
committed
UI review fixes.
1 parent 67edf66 commit 113a1d2

8 files changed

+11
-8
lines changed

vector/src/main/res/layout/fragment_other_sessions.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
android:id="@+id/deviceListOtherSessions"
112112
android:layout_width="0dp"
113113
android:layout_height="0dp"
114-
android:layout_marginTop="32dp"
114+
android:layout_marginTop="16dp"
115115
app:layout_constraintBottom_toBottomOf="parent"
116116
app:layout_constraintEnd_toEndOf="parent"
117117
app:layout_constraintStart_toStartOf="parent"

vector/src/main/res/layout/fragment_session_overview.xml

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
android:layout_width="0dp"
4848
android:layout_height="wrap_content"
4949
android:layout_marginHorizontal="8dp"
50+
android:layout_marginTop="4dp"
5051
android:text="@string/device_manager_session_overview_signout"
5152
app:layout_constraintEnd_toEndOf="parent"
5253
app:layout_constraintHorizontal_bias="0"

vector/src/main/res/layout/fragment_settings_devices.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
android:layout_width="0dp"
7676
android:layout_height="wrap_content"
7777
android:layout_marginHorizontal="16dp"
78-
android:layout_marginVertical="16dp"
78+
android:layout_marginVertical="4dp"
7979
app:layout_constraintEnd_toEndOf="parent"
8080
app:layout_constraintStart_toStartOf="parent"
8181
app:layout_constraintTop_toBottomOf="@id/deviceListHeaderCurrentSession" />

vector/src/main/res/layout/item_other_session.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
android:id="@+id/otherSessionSeparator"
9090
android:layout_width="0dp"
9191
android:layout_height="1dp"
92-
android:layout_marginTop="8dp"
92+
android:layout_marginTop="16dp"
9393
android:background="?vctr_content_quinary"
9494
app:layout_constraintEnd_toEndOf="parent"
9595
app:layout_constraintStart_toStartOf="@id/otherSessionNameTextView"

vector/src/main/res/layout/item_session_details_content.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
style="@style/TextAppearance.Vector.Body"
2323
android:layout_width="0dp"
2424
android:layout_height="wrap_content"
25-
android:layout_marginStart="8dp"
25+
android:layout_marginStart="12dp"
2626
android:layout_marginEnd="@dimen/layout_horizontal_margin"
2727
android:gravity="end"
2828
app:layout_constraintBottom_toTopOf="@id/sessionDetailsContentDivider"

vector/src/main/res/layout/view_other_sessions.xml

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
xmlns:app="http://schemas.android.com/apk/res-auto"
44
xmlns:tools="http://schemas.android.com/tools"
55
android:layout_width="match_parent"
6-
android:layout_height="match_parent">
6+
android:layout_height="match_parent"
7+
android:paddingBottom="8dp">
78

89
<androidx.recyclerview.widget.RecyclerView
910
android:id="@+id/otherSessionsRecyclerView"
@@ -19,8 +20,9 @@
1920
style="@style/Widget.Vector.Button.Text"
2021
android:layout_width="wrap_content"
2122
android:layout_height="wrap_content"
23+
android:layout_marginStart="72dp"
24+
android:layout_marginTop="4dp"
2225
android:padding="0dp"
23-
android:layout_marginStart="16dp"
2426
app:layout_constraintStart_toStartOf="@id/otherSessionsRecyclerView"
2527
app:layout_constraintTop_toBottomOf="@id/otherSessionsRecyclerView"
2628
tools:text="@string/device_manager_other_sessions_view_all" />

vector/src/main/res/layout/view_session_info.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
android:layout_height="wrap_content"
77
android:background="@drawable/bg_current_session"
88
android:paddingHorizontal="24dp"
9-
android:paddingBottom="16dp">
9+
android:paddingBottom="8dp">
1010

1111
<ImageView
1212
android:id="@+id/sessionInfoDeviceTypeImageView"

vector/src/main/res/layout/view_sessions_list_header.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
android:layout_width="0dp"
2525
android:layout_height="wrap_content"
2626
android:layout_marginHorizontal="@dimen/layout_horizontal_margin"
27-
android:layout_marginTop="18.5dp"
27+
android:layout_marginTop="@dimen/layout_vertical_margin"
2828
app:layout_constraintEnd_toEndOf="parent"
2929
app:layout_constraintStart_toStartOf="parent"
3030
app:layout_constraintTop_toBottomOf="@id/sessions_list_header_title"

0 commit comments

Comments
 (0)