Skip to content

Commit 69a5404

Browse files
committed
src: clean up embedder API
nodejs/node#35897
1 parent 6766b65 commit 69a5404

2 files changed

+12
-12
lines changed

patches/node/fix_expose_tracing_agent_and_use_tracing_tracingcontroller_instead.patch

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ index 34a16feaed229a59181e1b2e48b0e111d5b0b2a6..a649f52403659fd18898e1e813f97e32
3333
class TracingController;
3434

3535
}
36-
@@ -522,6 +523,8 @@ NODE_DEPRECATED("Use GetMultiIsolatePlatform(env) instead",
36+
@@ -484,6 +484,8 @@ NODE_EXTERN v8::MaybeLocal<v8::Value> PrepareStackTraceCallback(
3737
NODE_EXTERN MultiIsolatePlatform* GetMultiIsolatePlatform(Environment* env);
3838
NODE_EXTERN MultiIsolatePlatform* GetMultiIsolatePlatform(IsolateData* env);
3939

4040
+NODE_EXTERN node::tracing::Agent* CreateAgent();
4141
+
42-
// Legacy variants of MultiIsolatePlatform::Create().
43-
NODE_DEPRECATED("Use variant taking a v8::TracingController* pointer instead",
42+
NODE_DEPRECATED("Use MultiIsolatePlatform::Create() instead",
4443
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
44+
int thread_pool_size,

patches/node/src_allow_embedders_to_provide_a_custom_pageallocator_to.patch

+9-9
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,16 @@ index b646fdda58ebcbf2dd92ee4fc9cb0d9c039174d1..14893ad605b9f8c64b0b8fc28625e235
4848
};
4949

5050
enum IsolateSettingsFlags {
51-
@@ -536,7 +537,8 @@ NODE_DEPRECATED("Use variant taking a v8::TracingController* pointer instead",
52-
node::tracing::TracingController* tracing_controller));
53-
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
54-
int thread_pool_size,
55-
- v8::TracingController* tracing_controller);
56-
+ v8::TracingController* tracing_controller,
57-
+ v8::PageAllocator* = nullptr);
58-
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform);
51+
@@ -490,7 +490,8 @@ NODE_EXTERN node::tracing::Agent* CreateAgent();
52+
NODE_DEPRECATED("Use MultiIsolatePlatform::Create() instead",
53+
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
54+
int thread_pool_size,
55+
- v8::TracingController* tracing_controller));
56+
+ v8::TracingController* tracing_controller,
57+
+ v8::PageAllocator* = nullptr));
58+
NODE_DEPRECATED("Use MultiIsolatePlatform::Create() instead",
59+
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform));
5960

60-
// Get/set the currently active tracing controller. Using CreatePlatform()
6161
diff --git a/src/node_platform.cc b/src/node_platform.cc
6262
index aac0682670fcffd235fcf450bc5e2b0d45985b47..96be2281b562c44b276483970c06862250ea8941 100644
6363
--- a/src/node_platform.cc

0 commit comments

Comments
 (0)