Skip to content

Electron 7.1.3 broke github releases. Possible to change latest.yml manually #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
burtonator opened this issue Dec 18, 2019 · 5 comments
Closed
Labels

Comments

@burtonator
Copy link

  • Version:

    "electron-builder": "~21.2.0",

"electron-updater": "~4.2.0",
  • Target:
    macos, windows hosted on github.

Releases on Electron > 7.1.2 no longer work and give this error:

Error: Redirect was cancelled at SimpleURLLoaderWrapper. (electron/js2c/browser_init.js:2561:23) at SimpleURLLoaderWrapper.emit (events.js:203:13)

I suspect redirects are broken as it does fetch ONE URL but not the others.

I'd like to change the latest.yml file so it can fetch exact URLs but the 'url' is custom built by concat of the base + URL plus the download URL.

So I get this a URL like:

a+b

rather than just

b (it's already absolute)

that alone might be a bug and warrant fixing but I think if I can get latest.yml to specify a full URL I'll be good.

Is there documentation to the latest.yml format?

Downloading update from https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3-mac.zip?alt=media&token=5329f924-c99f-480e-85b2-41d832636736, https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3.dmg?alt=media&token=4ae0573f-e3d3-488b-87f8-587b53858ba9
Downloading update from https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3-mac.zip?alt=media&token=5329f924-c99f-480e-85b2-41d832636736, https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3.dmg?alt=media&token=4ae0573f-e3d3-488b-87f8-587b53858ba9
updater cache dir: /Users/burton/Library/Application Support/Caches/polar-bookshelf-updater
No cached update info available
Error: Error: Cannot download "https://github.com/burtonator/polar-bookshelf/releases/download/v1.80.3/https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3-mac.zip?alt=media&token=5329f924-c99f-480e-85b2-41d832636736", status 404: Not Found
    at ClientRequest.<anonymous> (/Applications/Polar Bookshelf.app/Contents/Resources/app.asar/node_modules/builder-util-runtime/out/httpExecutor.js:278:26)
    at ClientRequest.emit (events.js:203:13)
    at SimpleURLLoaderWrapper.<anonymous> (electron/js2c/browser_init.js:2527:12)
    at SimpleURLLoaderWrapper.emit (events.js:203:13)
(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.
[error] [1.70.4] Error handling updates: Error: Cannot download "https://github.com/burtonator/polar-bookshelf/releases/download/v1.80.3/https://firebasestorage.googleapis.com/v0/b/polar-32b0f.appspot.com/o/download%2FPolar-Bookshelf-1.80.3-mac.zip?alt=media&token=5329f924-c99f-480e-85b2-41d832636736", status 404: Not Found
@burtonator
Copy link
Author

I think the bug is here:

https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/electronHttpExecutor.ts#L27

We have a thread on this going here:

electron/electron#21566

I suspect maybe Electron >7.1.2 started properly handling redirects?

Is there a reason electron-updater isn't following redirect URLs? This will break a LOT of hosting platforms.

@marcoancona
Copy link

Also connected to #4505 (which is not solved)

@s00d
Copy link
Contributor

s00d commented Jan 13, 2020

electron 7.1.8 worked!

@lutzroeder
Copy link
Contributor

Duplicate of #4505

@stale
Copy link

stale bot commented Apr 1, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 1, 2020
@stale stale bot closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants