ci: Lint with XO

Author: pvdlg

lib/verify.js

@@ -1,7 +1,7 @@
-const verifyPkg = require('./verify-pkg');
-const setNpmrcAuth = require('./set-npmrc-auth');
 const execa = require('execa');
 const SemanticReleaseError = require('@semantic-release/error');
+const verifyPkg = require('./verify-pkg');
+const setNpmrcAuth = require('./set-npmrc-auth');
 
 module.exports = async (pkg, logger) => {
   verifyPkg(pkg);

package.json

@@ -32,39 +32,21 @@
     "cz-conventional-changelog": "^2.0.0",
     "delay": "^2.0.0",
     "dockerode": "^2.5.3",
-    "eslint": "^4.11.0",
     "eslint-config-prettier": "^2.5.0",
-    "eslint-config-standard": "^10.2.1",
-    "eslint-plugin-import": "^2.7.0",
-    "eslint-plugin-node": "^5.2.0",
     "eslint-plugin-prettier": "^2.3.0",
-    "eslint-plugin-promise": "^3.5.0",
-    "eslint-plugin-standard": "^3.0.1",
     "get-stream": "^3.0.0",
     "got": "^8.0.0",
     "nock": "^9.1.0",
     "nyc": "^11.2.1",
     "prettier": "~1.8.2",
-    "rimraf": "^2.5.0",
     "semantic-release": "^9.1.1",
     "sinon": "^4.1.2",
-    "tempy": "^0.2.1"
+    "tempy": "^0.2.1",
+    "xo": "^0.18.2"
   },
   "engines": {
     "node": ">=4"
   },
-  "eslintConfig": {
-    "extends": [
-      "standard",
-      "prettier"
-    ],
-    "plugins": [
-      "prettier"
-    ],
-    "rules": {
-      "prettier/prettier": 2
-    }
-  },
   "files": [
     "lib",
     "index.js"
@@ -105,12 +87,22 @@
     "url": "https://github.com/semantic-release/npm.git"
   },
   "scripts": {
-    "clean": "rimraf coverage && rimraf .nyc_output",
     "cm": "git-cz",
     "codecov": "codecov -f coverage/coverage-final.json",
-    "lint": "eslint test lib index.js",
-    "pretest": "npm run clean && npm run lint",
+    "lint": "xo",
+    "pretest": "npm run lint",
     "semantic-release": "semantic-release",
     "test": "nyc ava -v"
+  },
+  "xo": {
+    "extends": [
+      "prettier"
+    ],
+    "plugins": [
+      "prettier"
+    ],
+    "rules": {
+      "prettier/prettier": 2
+    }
   }
 }

test/get-last-release.test.js

@@ -3,19 +3,19 @@ import test from 'ava';
 import nock from 'nock';
 import {stub} from 'sinon';
 import tempy from 'tempy';
-import {registry, mock, available, unpublished} from './helpers/mock-registry';
 import lastRelease from '../lib/get-last-release';
+import {registry, mock, available, unpublished} from './helpers/mock-registry';
 
 let processStdout;
 let processStderr;
 
-test.before(t => {
+test.before(() => {
   // Disable npm logger during tests
   processStdout = stub(process.stdout, 'write');
   processStderr = stub(process.stderr, 'write');
 });
 
-test.beforeEach(async t => {
+test.beforeEach(t => {
   // Save the current process.env
   t.context.env = Object.assign({}, process.env);
   process.env.NPM_TOKEN = 'npm_token';
@@ -43,7 +43,7 @@ test.afterEach.always(t => {
   process.chdir(t.context.cwd);
 });
 
-test.after.always(t => {
+test.after.always(() => {
   // Restore stdout and stderr
   processStdout.restore();
   processStderr.restore();

test/helpers/npm-registry.js

@@ -42,7 +42,7 @@ async function start() {
 const url = `http://${SERVER_HOST}:${SERVER_PORT}/registry/_design/app/_rewrite/`;
 
 const authEnv = {
-  npm_config_registry: url,
+  npm_config_registry: url, // eslint-disable-line camelcase
   NPM_USERNAME,
   NPM_PASSWORD,
   NPM_EMAIL,

test/integration.test.js

@@ -11,15 +11,15 @@ import npmRegistry from './helpers/npm-registry';
 let processStderr;
 let processStdout;
 
-test.before(async t => {
+test.before(async () => {
   // Start the local NPM registry
   await npmRegistry.start();
   // Disable npm logger during tests
   processStderr = stub(process.stderr, 'write');
   processStdout = stub(process.stdout, 'write');
 });
 
-test.beforeEach(async t => {
+test.beforeEach(t => {
   // Save the current process.env
   t.context.env = Object.assign({}, process.env);
   // Delete env paramaters that could have been set on the machine running the tests
@@ -48,7 +48,7 @@ test.beforeEach(async t => {
   t.context.logger = {log: t.context.log};
 });
 
-test.afterEach.always(async t => {
+test.afterEach.always(t => {
   // Clear `rc` from the npm cache as it cache the relative path of .npmrc files, preventing to load a new file after changing current working directory
   clearModule('rc');
   // Restore process.env
@@ -57,7 +57,7 @@ test.afterEach.always(async t => {
   process.chdir(t.context.cwd);
 });
 
-test.after.always(async t => {
+test.after.always(async () => {
   // Stop the local NPM registry
   await npmRegistry.stop();
   // Restore stdout and stderr

test/set-npmrc-auth.test.js

@@ -6,7 +6,7 @@ import clearModule from 'clear-module';
 import SemanticReleaseError from '@semantic-release/error';
 import setNpmrcAuth from '../lib/set-npmrc-auth';
 
-test.beforeEach(async t => {
+test.beforeEach(t => {
   // Save the current process.env
   t.context.env = Object.assign({}, process.env);
   // Delete env paramaters that could have been set on the machine running the tests
@@ -113,7 +113,7 @@ test.serial('Throw error if "NPM_USERNAME" is missing', async t => {
   t.is(error.code, 'ENONPMTOKEN');
 });
 
-test.serial('Throw error if "NPM_USERNAME" is missing', async t => {
+test.serial('Throw error if "NPM_PASSWORD" is missing', async t => {
   process.env.NPM_USERNAME = 'npm_username';
   process.env.NPM_EMAIL = 'npm_email';
   const error = await t.throws(setNpmrcAuth({name: 'package-name'}, t.context.logger));

test/update-package-version.test.js

@@ -5,7 +5,7 @@ import execa from 'execa';
 import {stub} from 'sinon';
 import updatePackageVersion from '../lib/update-package-version';
 
-test.beforeEach(async t => {
+test.beforeEach(t => {
   t.context.cwd = process.cwd();
   process.chdir(tempy.directory());